Merge lp:~ajkavanagh/charms/trusty/mongodb/fix-unit-test-lint-lp1533654 into lp:charms/trusty/mongodb

Proposed by Alex Kavanagh
Status: Merged
Merged at revision: 83
Proposed branch: lp:~ajkavanagh/charms/trusty/mongodb/fix-unit-test-lint-lp1533654
Merge into: lp:charms/trusty/mongodb
Diff against target: 10 lines (+0/-2)
1 file modified
unit_tests/test_write_log_rotate_config.py (+0/-2)
To merge this branch: bzr merge lp:~ajkavanagh/charms/trusty/mongodb/fix-unit-test-lint-lp1533654
Reviewer Review Type Date Requested Status
Review Queue (community) automated testing Needs Fixing
José Antonio Rey (community) Approve
Ryan Beisner (community) Approve
Review via email: mp+282472@code.launchpad.net

Description of the change

Removed sys.path.append('hooks') from unit_tests/test_write_log_rotate_config.py as it is superflous and causes (new) flake8 to fail with an E402.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #17248 mongodb for ajkavanagh mp282472
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/17248/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #16114 mongodb for ajkavanagh mp282472
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/16114/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Thanks for the quick fix.

review: Approve
Revision history for this message
Ryan Beisner (1chb1n) wrote :
Revision history for this message
Ryan Beisner (1chb1n) wrote :
Revision history for this message
José Antonio Rey (jose) wrote :

+1 LGTM

review: Approve
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/2175/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/2156/

review: Needs Fixing (automated testing)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'unit_tests/test_write_log_rotate_config.py'
2--- unit_tests/test_write_log_rotate_config.py 2014-12-09 15:07:49 +0000
3+++ unit_tests/test_write_log_rotate_config.py 2016-01-13 17:24:21 +0000
4@@ -2,8 +2,6 @@
5 import os
6 import unittest
7 import tempfile
8-import sys
9-sys.path.append('hooks')
10 import hooks
11
12

Subscribers

People subscribed via source and target branches