Merge lp:~ajite/product-kitting/7.0-product-kitting-fix-0001 into lp:product-kitting

Status: Merged
Merged at revision: 8
Proposed branch: lp:~ajite/product-kitting/7.0-product-kitting-fix-0001
Merge into: lp:product-kitting
Diff against target: 12 lines (+1/-1)
1 file modified
purchase_bom_split/purchase.py (+1/-1)
To merge this branch: bzr merge lp:~ajite/product-kitting/7.0-product-kitting-fix-0001
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp code review Approve
Pedro Manuel Baeza code review Approve
Alexandre Fayolle - camptocamp code review, no test Approve
Review via email: mp+209636@code.launchpad.net

Description of the change

Fixed a bug that was preventing the confirmation of all purchase orders.

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM

Thanks for the patch Augustin. In the future, it's better to file a bug report for such an issue as people facing this will find the bug report more easily than the MP.

review: Approve (code review, no test)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Augustin Cisterne-Kaas - www.elico-corp.com (ajite) wrote :

Thanks Alexandre,

Well noted. I will do that next time.

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Thanks

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'purchase_bom_split/purchase.py'
2--- purchase_bom_split/purchase.py 2012-07-24 12:27:35 +0000
3+++ purchase_bom_split/purchase.py 2014-03-06 10:40:24 +0000
4@@ -116,7 +116,7 @@
5 move_id = move_obj.create(cr, uid, vals, context=context)
6 new_move_ids.append(move_id)
7 if move_dest_id:
8- line.move_dest_id.write({'location_id': move_dest_id})
9+ line.move_dest_id.write({'location_id': move_dest_id.location_id.id})
10
11 move_obj.action_confirm(cr, uid, new_move_ids)
12 move_obj.force_assign(cr, uid, new_move_ids)

Subscribers

People subscribed via source and target branches