Merge lp:~ajalkane/ubuntu-filemanager-app/remove-goto-action-from-header into lp:ubuntu-filemanager-app

[Arto Jalkanen]

Bug 1386209: Removed the "Go To" action from header in phone mode, as it's more accessible from Places bottom edge page.

Bug 1386209: Removed the "Go To" action from header in phone mode, as it's more accessible from Places bottom edge page.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:320
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/377/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1430
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1430/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-utopic-amd64-ci/173

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/377/rebuild

review: Approve (continuous-integration)

[Carlos Jose Mazieri (carlos-mazieri)]

Agree.

review: Approve

[David Planella (dpm)]

Looks good to me too, but what will be the behaviour in tablet mode? Will both the action and the places bottom edge be shown?

review: Needs Information

[Arto Jalkanen (ajalkane)]

> Looks good to me too, but what will be the behaviour in tablet mode? Will both
> the action and the places bottom edge be shown?

Tablet mode is not changed - Go To is in header, no places bottom edge (places are in left sidebar).

[David Planella (dpm)]

Awesome, LGTM, then!

review: Approve

=== modified file 'src/app/qml/ui/FolderListPage.qml'
--- src/app/qml/ui/FolderListPage.qml	2014-10-28 23:34:49 +0000
+++ src/app/qml/ui/FolderListPage.qml	2014-11-01 23:49:24 +0000
@@ -107,6 +107,7 @@
             id: gotoButton
             iconName: "find"
             text: i18n.tr("Go To")
+            visible: sidebar.expanded
             onTriggered: PopupUtils.open(Qt.resolvedUrl("GoToDialog.qml"), parent)
         },
         Action {