Merge lp:~ajalkane/ubuntu-filemanager-app/placeholder-icons-for-toolbar into lp:ubuntu-filemanager-app

Proposed by Arto Jalkanen
Status: Merged
Approved by: Arto Jalkanen
Approved revision: 31
Merged at revision: 30
Proposed branch: lp:~ajalkane/ubuntu-filemanager-app/placeholder-icons-for-toolbar
Merge into: lp:ubuntu-filemanager-app
Diff against target: 94 lines (+15/-4)
3 files modified
FileActionDialog.qml (+3/-1)
FolderListPage.qml (+8/-0)
FolderListView.qml (+4/-3)
To merge this branch: bzr merge lp:~ajalkane/ubuntu-filemanager-app/placeholder-icons-for-toolbar
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Arto Jalkanen Approve
Review via email: mp+164247@code.launchpad.net

Commit message

Placeholder icons for toolbar.

Description of the change

Placeholder icons for toolbar.

To post a comment you must log in.
Revision history for this message
Arto Jalkanen (ajalkane) wrote :

Aye

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'FileActionDialog.qml'
2--- FileActionDialog.qml 2013-04-17 17:55:41 +0000
3+++ FileActionDialog.qml 2013-05-16 18:52:25 +0000
4@@ -18,12 +18,14 @@
5 import QtQuick 2.0
6 import Ubuntu.Components 0.1
7 import Ubuntu.Components.Popups 0.1
8+import org.nemomobile.folderlistmodel 1.0
9
10 Dialog {
11 id: root
12
13 property string fileName
14 property string filePath
15+ property FolderListModel folderListModel
16
17 title: i18n.tr("Choose action")
18 text: i18n.tr("For file: ") + fileName
19@@ -32,7 +34,7 @@
20 text: i18n.tr("Open")
21 onClicked: {
22 console.log("Opening file", filePath)
23- Qt.openUrlExternally("file://" + filePath)
24+ folderListModel.openPath(filePath)
25 onClicked: PopupUtils.close(root)
26 }
27 }
28
29=== modified file 'FolderListPage.qml'
30--- FolderListPage.qml 2013-05-16 14:59:43 +0000
31+++ FolderListPage.qml 2013-05-16 18:52:25 +0000
32@@ -53,6 +53,8 @@
33
34 back: Action {
35 text: i18n.tr("Up")
36+ // TODO: temporary
37+ iconSource: "/usr/share/icons/Humanity/actions/48/up.svg"
38 onTriggered: {
39 pageModel.path = pageModel.parentPath
40 console.log("Up triggered")
41@@ -61,6 +63,8 @@
42 }
43 Action {
44 text: i18n.tr("Paste" + " (" + pageModel.clipboardUrlsCounter + ")")
45+ // TODO: temporary
46+ iconSource: "/usr/share/icons/Humanity/actions/48/edit-paste.svg"
47 onTriggered: {
48 console.log("Pasting to current folder items of count " + pageModel.clipboardUrlsCounter)
49 PopupUtils.open(Qt.resolvedUrl("FileOperationProgressDialog.qml"),
50@@ -81,6 +85,8 @@
51 // file manipulation operations
52 Action {
53 text: i18n.tr("Create folder")
54+ // TODO: temporary
55+ iconSource: "/usr/share/icons/Humanity/actions/48/folder-new.svg"
56 onTriggered: {
57 print(text)
58 PopupUtils.open(createFolderDialog, root)
59@@ -89,6 +95,8 @@
60
61 Action {
62 text: i18n.tr("Home")
63+ // TODO: temporary
64+ iconSource: "/usr/share/icons/Humanity/actions/48/go-home.svg"
65 onTriggered: {
66 pageModel.path = pageModel.homePath()
67 console.log("Home triggered")
68
69=== modified file 'FolderListView.qml'
70--- FolderListView.qml 2013-04-23 16:54:17 +0000
71+++ FolderListView.qml 2013-05-16 18:52:25 +0000
72@@ -157,6 +157,7 @@
73
74 delegate: FolderListDelegate {
75 id: delegate
76+
77 onClicked: {
78 if (model.isDir) {
79 if (model.isReadable && model.isExecutable) {
80@@ -172,11 +173,11 @@
81 }
82 } else {
83 console.log("Non dir clicked")
84- PopupUtils.open(Qt.resolvedUrl("FileActionDialog.qml"), delegate,
85+ PopupUtils.open(Qt.resolvedUrl("FileActionDialog.qml"), root,
86 {
87 fileName: model.fileName,
88- filePath: model.filePath
89-
90+ filePath: model.filePath,
91+ folderListModel: root.folderListModel
92 })
93 }
94 }

Subscribers

People subscribed via source and target branches