Merge lp:~ajalkane/ubuntu-filemanager-app/parentPathFunction into lp:ubuntu-filemanager-app

Proposed by Arto Jalkanen
Status: Merged
Approved by: Arto Jalkanen
Approved revision: 16
Merged at revision: 15
Proposed branch: lp:~ajalkane/ubuntu-filemanager-app/parentPathFunction
Merge into: lp:ubuntu-filemanager-app
Diff against target: 12 lines (+1/-1)
1 file modified
FolderListPage.qml (+1/-1)
To merge this branch: bzr merge lp:~ajalkane/ubuntu-filemanager-app/parentPathFunction
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Arto Jalkanen Approve
Review via email: mp+155067@code.launchpad.net

Commit message

parentPath is function in qml plugin instead of needlessly being property. Change to QML.

Description of the change

parentPath is function in qml plugin instead of needlessly being property. Change to QML.

To post a comment you must log in.
Revision history for this message
Arto Jalkanen (ajalkane) :
review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~ajalkane/ubuntu-filemanager-app/parentPathFunction/+merge/155067/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
Arto Jalkanen (ajalkane) wrote :

Here's your comment Jenkins, it's the same as in "Description of change" : parentPath is function in qml plugin instead of needlessly being property. Change to QML.

Btw. Jenkins, if you're going to fail my merge request without comment, why do you have the "Comment" field as "Optional" ? Nevermind, I shouldn't try to talk with bots.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:16
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~ajalkane/ubuntu-filemanager-app/parentPathFunction/+merge/155067/+edit-commit-message

http://91.189.93.125:8080/job/ubuntu-filemanager-app-ci/7/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-filemanager-app-quantal-amd64-ci/7/console
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-filemanager-app-raring-amd64-ci/7/console

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/ubuntu-filemanager-app-ci/7/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'FolderListPage.qml'
2--- FolderListPage.qml 2013-03-19 20:21:44 +0000
3+++ FolderListPage.qml 2013-03-22 21:07:22 +0000
4@@ -18,7 +18,7 @@
5 back: Action {
6 text: i18n.tr("Up")
7 onTriggered: {
8- pageModel.path = pageModel.parentPath
9+ pageModel.path = pageModel.parentPath()
10 console.log("Up triggered")
11 }
12 visible: pageModel.path != "/"

Subscribers

People subscribed via source and target branches