Merge lp:~ajalkane/ubuntu-filemanager-app/folderpage-size-adjustment into lp:ubuntu-filemanager-app

[Arto Jalkanen]

Readjusted file listing view height for new SDK changes

Readjusted file listing view height for new SDK changes.

With these changes the main view fills perfectly (on Desktop at least) the usable space without going over toolbar nor leaving extra space.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:50
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~ajalkane/ubuntu-filemanager-app/folderpage-size-adjustment/+merge/175699/+edit-commit-message

http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/9/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-precise-amd64-ci/7
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-quantal-amd64-ci/10
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-raring-amd64-ci/10
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-saucy-amd64-ci/7

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/9/rebuild

review: Needs Fixing (continuous-integration)

[Michael Spencer (ibelieve)]

Nice (if I can say nice for a hack around a bug).

Neither of those bugs you list really seem related to the problem. I've filed a separate bug (https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1202881), could you change the links to point to the new bug?

review: Needs Fixing

[Arto Jalkanen (ajalkane)]

Sure thing, I readjusted the comments!

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:51
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/10/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-precise-amd64-ci/8
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-quantal-amd64-ci/11
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-raring-amd64-ci/11
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-saucy-amd64-ci/8

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/10/rebuild

review: Approve (continuous-integration)

[Michael Spencer (ibelieve)]

review: Approve

=== modified file 'FolderListPage.qml'
--- FolderListPage.qml	2013-07-11 22:47:16 +0000
+++ FolderListPage.qml	2013-07-19 04:04:26 +0000
@@ -373,9 +373,18 @@
         // IMPROVE: this should work (?), but it doesn't. Height is undefined. Anyway in previous
         // SDK version the parent size was properly initialized. Now the size of toolbar is not taken into
         // account and apparently you can't even query toolbar's height.
-     // anchors.bottomMargin: toolbar.height
-        // So hard-code it. Not nice at all:
-        anchors.bottomMargin: units.gu(8)
+        // anchors.bottomMargin: toolbar.height
+        // Now in newer SDK (raring 19.07.2013) locked&opened toolbar is taken into
+        // account in some fashion, but the extra space left to the bottom without this
+        // bottomMargin definition seems to be exactly what is the height of Header's gray
+        // separator bar. This ugly workaround seems to give correct height for view at least on desktop.
+        // Bug report on this:
+        // https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1202881
+        // This bug report also affects this, as if the toolbar is hidden by default
+        // then there is no problem:
+        // https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1198861
+        // Hard-code it for now. Not nice at all:
+        anchors.bottomMargin: units.gu(-2)
     }
 
     // Errors from model