Merge lp:~aisrael/charms/trusty/vem/lint-cleanup into lp:charms/trusty/vem
Proposed by
Adam Israel
Status: | Merged |
---|---|
Approved by: | Charles Butler |
Approved revision: | 6 |
Merge reported by: | Charles Butler |
Merged at revision: | not available |
Proposed branch: | lp:~aisrael/charms/trusty/vem/lint-cleanup |
Merge into: | lp:charms/trusty/vem |
Diff against target: |
120 lines (+21/-18) 4 files modified
Makefile (+11/-7) hooks/common.py (+8/-8) hooks/config_changed.py (+2/-2) revision (+0/-1) |
To merge this branch: | bzr merge lp:~aisrael/charms/trusty/vem/lint-cleanup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Butler (community) | Approve | ||
Review via email: mp+234406@code.launchpad.net |
Description of the change
Removed legacy revision file
Fixed lint issues w/hooks/common.py and hooks/config_
Added virtualenv to Makefile so dependencies are met through automated tests.
I wasn't able to fully run the tests. It might be something with my environment (running under vagrant). nova-compute was failing to fully install because the upstart script was attempting to modprobe nbd. I manually modprobed the module on the host machine, commented out the modprobe in /etc/init/
To post a comment you must log in.
Adam,
Thanks for the proofing, lint, and CI cleanup!
The tests fail when being run against a cloud provider, but this is not in relation to your changes to fixup proof and run the tests in a provided virtualenv.
I'm going to merge this with a follow up ping to Jorge Niedbalski who is the technical contact that has worked with cisco on the production of this charm.
Thanks again for your efforts +1 LGTM