Merge lp:~aisrael/charms/trusty/memcached/noipv6 into lp:charms/trusty/memcached

Proposed by Adam Israel on 2015-02-13
Status: Work in progress
Proposed branch: lp:~aisrael/charms/trusty/memcached/noipv6
Merge into: lp:charms/trusty/memcached
Diff against target: 10 lines (+1/-1)
1 file modified
hooks/memcached_hooks.py (+1/-1)
To merge this branch: bzr merge lp:~aisrael/charms/trusty/memcached/noipv6
Reviewer Review Type Date Requested Status
Charles Butler 2015-02-13 Needs Fixing on 2015-03-23
Review via email: mp+249707@code.launchpad.net

Description of the Change

The previous revision synced charm-helpers to enable detection of (or lack thereof) ipv6 networking. This merge proposal adds the soft_fail=True param to ufw.enable() so that, if ipv6 is not available, the installation continues using only ipv4 instead of failing with `charmhelpers.contrib.network.ufw.UFWIPv6Error: IPv6 firewall support broken`.

To post a comment you must log in.
Charles Butler (lazypower) wrote :

Greetings Adam,

This MP appears to have gone a bit stale with the charm and does not apply cleanly anymore. Can you give this another look and re-open once you've validated this is still an applicable fix?

Thanks!

review: Needs Fixing
Kevin W Monroe (kwmonroe) wrote :

This may be moot. memcached now has an allow-ufw-ip6-softfail config option:

http://bazaar.launchpad.net/~charmers/charms/trusty/memcached/trunk/revision/67#config.yaml

Setting that to True when deploying with the local provider should allow for successful deployments to lxc.

Unmerged revisions

65. By Adam Israel on 2015-02-13

Turn on ufw's soft_fail, so install doesn't fail if ipv6 isn't available

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/memcached_hooks.py'
2--- hooks/memcached_hooks.py 2014-12-19 18:24:29 +0000
3+++ hooks/memcached_hooks.py 2015-02-13 19:57:49 +0000
4@@ -53,7 +53,7 @@
5 with open(ETC_DEFAULT_MEMCACHED, 'w') as f:
6 f.write('ENABLE_MEMCACHED=yes\n')
7
8- ufw.enable()
9+ ufw.enable(soft_fail=True)
10 ufw.service('ssh', 'open')
11
12

Subscribers

People subscribed via source and target branches