Merge lp:~ailurius/ubuntu/quantal/gnome-control-center/fix-for-993440 into lp:ubuntu/quantal/gnome-control-center

Proposed by Ada Wah
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~ailurius/ubuntu/quantal/gnome-control-center/fix-for-993440
Merge into: lp:ubuntu/quantal/gnome-control-center
Diff against target: 47 lines (+27/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/power_suspend_on_critical.patch (+19/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~ailurius/ubuntu/quantal/gnome-control-center/fix-for-993440
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Needs Resubmitting
Ubuntu branches Pending
Review via email: mp+133570@code.launchpad.net

Description of the change

Add "Suspend" as an optional action for critical battery level.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Joakim!

Thanks for you patch and help to make ubuntu better :)
We try to not add strings to existing ubuntu release, because they won't be translated. Also, this change the behavior by introducing more options to people on an existing release and the SRU policy is to avoid doing that.

I think this patch may be discussed (can you take it upstream as well?) and should be rebase on raring, which will probably use gnome-control-center 4.6. Do you mind proposing it against lp:~ubuntu-desktop/gnome-control-center/ubuntu? (This is where desktop packaging are handled, see Bzr-Vcs in debian/control pointing to it).

Thanks agian, will reject the branch for now.

review: Needs Resubmitting

Unmerged revisions

271. By Ada Wah

* debian/patches/power_suspend_on_critical.patch:
  - added suspend as an option for critical battery level (lp: #993440)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-10-09 17:03:35 +0000
3+++ debian/changelog 2012-11-08 21:53:18 +0000
4@@ -1,3 +1,10 @@
5+gnome-control-center (1:3.4.2-0ubuntu20) UNRELEASED; urgency=low
6+
7+ * debian/patches/power_suspend_on_critical.patch:
8+ - added suspend as an option for critical battery level (lp: #993440)
9+
10+ -- Joakim Langvand <jlangvand@gmail.com> Thu, 08 Nov 2012 22:38:11 +0100
11+
12 gnome-control-center (1:3.4.2-0ubuntu19) quantal; urgency=low
13
14 * debian/patches/clutter_init.patch:
15
16=== added file 'debian/patches/power_suspend_on_critical.patch'
17--- debian/patches/power_suspend_on_critical.patch 1970-01-01 00:00:00 +0000
18+++ debian/patches/power_suspend_on_critical.patch 2012-11-08 21:53:18 +0000
19@@ -0,0 +1,19 @@
20+## Description: add some description
21+## Origin/Author: add some origin or author
22+## Bug: bug URL
23+Index: gnome-control-center.dev/panels/power/power.ui
24+===================================================================
25+--- gnome-control-center.dev.orig/panels/power/power.ui 2012-11-08 22:26:58.463011000 +0100
26++++ gnome-control-center.dev/panels/power/power.ui 2012-11-08 22:38:03.075415394 +0100
27+@@ -12,6 +12,11 @@
28+ </columns>
29+ <data>
30+ <row>
31++ <col id="0" translatable="yes">Suspend</col>
32++ <col id="1">1</col>
33++ <col id="2">True</col>
34++ </row>
35++ <row>
36+ <col id="0" translatable="yes">Hibernate</col>
37+ <col id="1">3</col>
38+ <col id="2">True</col>
39
40=== modified file 'debian/patches/series'
41--- debian/patches/series 2012-10-09 17:03:35 +0000
42+++ debian/patches/series 2012-11-08 21:53:18 +0000
43@@ -45,3 +45,4 @@
44 power_cancellable_fixes.patch
45 git_fix_big_editable_labels.patch
46 git_unmute_sound_event.patch
47+power_suspend_on_critical.patch

Subscribers

People subscribed via source and target branches

to all changes: