Merge ~aieri/charm-nagios:bug/1811997 into ~nagios-charmers/charm-nagios:master

[Andrea Ieri]

Write all password files with mode 0400

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Giuseppe Petralia (peppepetra)]

Needs fixing

review: Needs Fixing

[Giuseppe Petralia (peppepetra)]

lgtm

review: Approve

[Xav Paice (xavpaice)]

Trivial change, will merge without Canonical IS Reviewers input (been a couple of weeks waiting now).

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision ac353d33f77c7d62d42c0cc5526b07669736ee30

diff --git a/hooks/upgrade-charm b/hooks/upgrade-charm
index 1016391..b5e9447 100755
--- a/hooks/upgrade-charm
+++ b/hooks/upgrade-charm
@@ -351,6 +351,7 @@ def update_password(account, password):
     if password:
         with open(account_file, 'w') as f:
             f.write(password)
+            os.fchmod(f.fileno(), 0o0400)
         subprocess.call(['htpasswd', '-b', '/etc/nagios3/htpasswd.users',
                          account, password])
     else: