Merge lp:~ahayzen/webbrowser-app/fix-1568740-bottom-edge-hint-overlaps into lp:webbrowser-app

Proposed by Andrew Hayzen
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1536
Merged at revision: 1540
Proposed branch: lp:~ahayzen/webbrowser-app/fix-1568740-bottom-edge-hint-overlaps
Merge into: lp:webbrowser-app
Diff against target: 11 lines (+1/-0)
1 file modified
src/app/webbrowser/Browser.qml (+1/-0)
To merge this branch: bzr merge lp:~ahayzen/webbrowser-app/fix-1568740-bottom-edge-hint-overlaps
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
system-apps-ci-bot continuous-integration Needs Fixing
Review via email: mp+306334@code.launchpad.net

Commit message

* Clip the Loader containing NewTabView so that it doesn't overlap the bottom edge hint

Description of the change

* Clip the Loader containing NewTabView so that it doesn't overlap the bottom edge hint

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1536
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/652/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/1591
    UNSTABLE: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/379
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1591
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1439
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1439/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1439
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1439/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1439
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1439/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1439
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1439/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1439
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1439/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1439
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1439/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1439
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1439/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1439
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1439/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1439
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1439/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/652/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

LGTM, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/Browser.qml'
2--- src/app/webbrowser/Browser.qml 2016-07-01 08:52:37 +0000
3+++ src/app/webbrowser/Browser.qml 2016-09-21 13:34:35 +0000
4@@ -261,6 +261,7 @@
5 fill: tabContainer
6 topMargin: (chrome.state == "shown") ? chrome.height : 0
7 }
8+ clip: true // prevents component from overlapping bottom edge etc
9
10 // Avoid loading the new tab view if the webview is about to load
11 // content. Since WebView.restoreState is not a notifyable property,

Subscribers

People subscribed via source and target branches

to status/vote changes: