Ubuntu Weather App

Code review comment for lp:~ahayzen/ubuntu-weather-app/reboot-uc1.3-bump

  1. reboot-uc1.3-bump
  2. Merge into reboot
Revision history for this message
Victor Thompson (vthompson) wrote :

Please also bump the new NoAPIKeyErrorStateComponent to 1.3

I still see all the same odd header behaviors.

I'm not sure I agree with using "Weather" as the title. The title on the desktop did not change with this MP, so fixing it here doesn't seem necessary. I don't think the user should see "Weather" as the header is hidden/shown.

I think you need to rebuild the pot file? It seems your mp is removing some stuff.

review: Needs Fixing

« Back to merge proposal