Code review comment for lp:~ahayzen/ubuntu-weather-app/reboot-fix-no-settings-button-empty-state

Victor Thompson (vthompson) wrote :

One more thing, I've suggested this before--but I think we should disable the bottom edge hint when the empty state is visible. One more reason why I think we should is that otherwise we'll want another empty state for that view. There's no additional actions the user can take from the bottom edge when the empty state is shown that they can't do from the empty state. So why have duplicate entry points and excessive empty states?

Or--and this is contradictory in a sense from what I just said-- maybe we should remove the button on this empty state and instead instruct the user how to use the bottom edge? Then we'd eventually want to add an empty state to that view as well.

I'm inclined to think that instructing the user to use the bottom edge in this case is the best option.

« Back to merge proposal