Code review comment for lp:~ahayzen/ubuntu-weather-app/reboot-fix-no-settings-button-empty-state

Revision history for this message
Victor Thompson (vthompson) wrote :

So I know these two things weren't introduced by this MP, but they are probably worth discussing and fixing here:

1. In the Empty State when location detection is off, the phrase "Searching for current location" is inaccurate. When location detection is off, we should probably say "Cannot determine your location" or similar.
2. Ideally we should also display the above when the user denies the request to share location with the app. But I'm not going to require that you do so under this MP.
3. IMO "Add a manual location" doesn't make a whole lot of sense. I think we should change this to "Manually add a location" or maybe even "Search for a location"

For the first two, I think eventually we should add a graphic to the Empty State to make this view more friendly. Something fun like this: http://i.imgur.com/XJC58qk.jpg

review: Needs Fixing

« Back to merge proposal