Code review comment for lp:~ahayzen/ubuntu-weather-app/reboot-day-delegate-expand

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

I've removed the auto scroll for now as it was becoming messy when you had one item expanded and you go to click on another, as it collapses one and expands the other the height then moves around a lot, let me know if you do infact want this in.

I've also changed the way the flickable's height is calculated, let me know if it is slightly too tight to the bottom item.

Regarding collapsing delegates I went with collapsing when either of the following occur:
- Another delegate is expanded
- The selected location changes
- The HomePage becomes invisible (another page pushed on top in the stack)

Let me know if you want any changes regarding this behaviour :)

« Back to merge proposal