Code review comment for lp:~ahayzen/ubuntu-weather-app/reboot-1452497-add-location-from-home

Revision history for this message
Victor Thompson (vthompson) wrote :

On my first 3 runs the search test failed:

Traceback (most recent call last):
  File "/home/victor/Development/reboot-1452497-add-location-from-home/tests/autopilot/ubuntu_weather_app/tests/test_add_location_page.py", line 84, in test_add_location_via_search
    self.assertThat(self.locations_page.visible, Eventually(Equals(True)))
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 423, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: After 10.0 seconds test on LocationsPage.visible failed: True != dbus.Boolean(False, variant_level=1)

I didn't think you'd want to add a timer to the app to get a delay--I assumed you'd add a delay to the test.

« Back to merge proposal