Merge lp:~ahayzen/ubuntu-weather-app/reboot-1452497-add-location-from-empty-state into lp:ubuntu-weather-app
Status: | Rejected |
---|---|
Rejected by: | Andrew Hayzen on 2015-07-29 |
Proposed branch: | lp:~ahayzen/ubuntu-weather-app/reboot-1452497-add-location-from-empty-state |
Merge into: | lp:ubuntu-weather-app |
Diff against target: |
74 lines (+31/-0) 4 files modified
app/ui/AddLocationPage.qml (+1/-0) debian/changelog (+1/-0) tests/autopilot/ubuntu_weather_app/__init__.py (+5/-0) tests/autopilot/ubuntu_weather_app/tests/test_empty_state.py (+24/-0) |
To merge this branch: | bzr merge lp:~ahayzen/ubuntu-weather-app/reboot-1452497-add-location-from-empty-state |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrew Hayzen | Disapprove on 2015-07-29 | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve on 2015-07-27 | |
Review via email:
|
Commit message
* Add autopilot test which adds a location from empty state page via cached location list
Description of the change
* Add autopilot test which adds a location from empty state page via cached location list
This tests that you can add a location from the empty state page via selecting the add button and then using the pre cached location list.
Victor Thompson (vthompson) wrote : | # |
I want to hold on merging this until we decide how to do the empty state action, per my comment on your other mp [1].
Andrew Hayzen (ahayzen) wrote : | # |
Going to abandon this as the tests are moving into their own branch with [2] and they are very similar so I'm going to fold the changes into that branch.
2 - lp:~ahayzen/ubuntu-weather-app/reboot-1452497-add-location-from-home
Unmerged revisions
- 73. By Andrew Hayzen on 2015-07-27
-
* Alphabetical OCD
- 72. By Andrew Hayzen on 2015-07-27
-
* Add autopilot test which adds a location from empty state page via cached location list
PASSED: Continuous integration, rev:73 91.189. 93.70:8080/ job/ubuntu- weather- app-reboot- ci/161/ 91.189. 93.70:8080/ job/ubuntu- weather- app-reboot- utopic- amd64-ci/ 131 91.189. 93.70:8080/ job/ubuntu- weather- app-reboot- vivid-amd64- ci/161
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- weather- app-reboot- ci/161/ rebuild
http://