Merge lp:~ahayzen/ubuntu-weather-app/finish-snapcraft-implementation-001 into lp:ubuntu-weather-app
Proposed by
Andrew Hayzen
Status: | Merged |
---|---|
Approved by: | Pat McGowan |
Approved revision: | 253 |
Merged at revision: | 256 |
Proposed branch: | lp:~ahayzen/ubuntu-weather-app/finish-snapcraft-implementation-001 |
Merge into: | lp:ubuntu-weather-app |
Diff against target: |
65 lines (+21/-14) 2 files modified
setup/gui/ubuntu-weather-app.desktop (+1/-1) snapcraft.yaml (+20/-13) |
To merge this branch: | bzr merge lp:~ahayzen/ubuntu-weather-app/finish-snapcraft-implementation-001 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jenkins Bot | continuous-integration | Approve | |
Pat McGowan | Approve | ||
Review via email: mp+313490@code.launchpad.net |
Commit message
* Add correct plugs to work when confined
* Correct path for icon in desktop file
Description of the change
* Add correct plugs to work when confined
* Correct path for icon in desktop file
Note that you have to inject the API keys into the app/data/keys.js before running snapcraft.
To post a comment you must log in.
Reviewed the yaml, built and tested snap under unity7 desktop, lgtm