Merge lp:~ahayzen/ubuntu-ui-extras/printer-components-use-try-compare-job-model-test into lp:~phablet-team/ubuntu-ui-extras/printer-components

Proposed by Andrew Hayzen
Status: Work in progress
Proposed branch: lp:~ahayzen/ubuntu-ui-extras/printer-components-use-try-compare-job-model-test
Merge into: lp:~phablet-team/ubuntu-ui-extras/printer-components
Diff against target: 25 lines (+2/-2)
2 files modified
po/ubuntu-ui-extras.pot (+1/-1)
tests/unittests/Printers/tst_jobmodel.cpp (+1/-1)
To merge this branch: bzr merge lp:~ahayzen/ubuntu-ui-extras/printer-components-use-try-compare-job-model-test
Reviewer Review Type Date Requested Status
Andrew Hayzen (community) Disapprove
Review via email: mp+317976@code.launchpad.net

Commit message

* Change test to use QTRY_COMPARE instead of QCOMPARE as it is failing in silo builds

Description of the change

* Change test to use QTRY_COMPARE instead of QCOMPARE as it is failing in silo builds

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

This doesn't seem to solve the problem, but possibly helped a bit.

review: Disapprove

Unmerged revisions

129. By Andrew Hayzen

* Change test to use QTRY_COMPARE instead of QCOMPARE as it is failing in silo builds

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/ubuntu-ui-extras.pot'
2--- po/ubuntu-ui-extras.pot 2017-02-21 10:46:29 +0000
3+++ po/ubuntu-ui-extras.pot 2017-02-22 14:06:12 +0000
4@@ -8,7 +8,7 @@
5 msgstr ""
6 "Project-Id-Version: ubuntu-ui-extras\n"
7 "Report-Msgid-Bugs-To: \n"
8-"POT-Creation-Date: 2017-02-21 10:42+0000\n"
9+"POT-Creation-Date: 2017-02-22 14:01+0000\n"
10 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
11 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
12 "Language-Team: LANGUAGE <LL@li.org>\n"
13
14=== modified file 'tests/unittests/Printers/tst_jobmodel.cpp'
15--- tests/unittests/Printers/tst_jobmodel.cpp 2017-02-21 10:46:29 +0000
16+++ tests/unittests/Printers/tst_jobmodel.cpp 2017-02-22 14:06:12 +0000
17@@ -108,7 +108,7 @@
18 // Triggers a change.
19 QSignalSpy changedSpy(m_model, SIGNAL(dataChanged(const QModelIndex&, const QModelIndex&, const QVector<int>&)));
20 m_backend->mockJobCreated("", "", "", 1, "", true, 100, 1, "", "", 1);
21- QCOMPARE(changedSpy.count(), 1);
22+ QTRY_COMPARE(changedSpy.count(), 1);
23 }
24
25 private:

Subscribers

People subscribed via source and target branches