Merge lp:~ahayzen/ubuntu-printing-app/rearrange-folders into lp:ubuntu-printing-app

Proposed by Andrew Hayzen
Status: Merged
Approved by: Michael Sheldon
Approved revision: 49
Merged at revision: 34
Proposed branch: lp:~ahayzen/ubuntu-printing-app/rearrange-folders
Merge into: lp:ubuntu-printing-app
Prerequisite: lp:~dobey/ubuntu-printing-app/add-notifier-daemon
Diff against target: 607 lines (+198/-173)
14 files modified
CMakeLists.txt (+1/-46)
debian/control (+1/-0)
po/CMakeLists.txt (+12/-44)
po/ubuntu-printing-app.pot (+139/-70)
ubuntu-printing-app/CMakeLists.txt (+36/-4)
ubuntu-printing-app/tests/qmltests/CMakeLists.txt (+1/-1)
ubuntu-printing-app/tests/qmltests/tst_CheckBoxRow.qml (+1/-1)
ubuntu-printing-app/tests/qmltests/tst_LabelRow.qml (+1/-1)
ubuntu-printing-app/tests/qmltests/tst_PreviewRow.qml (+1/-1)
ubuntu-printing-app/tests/qmltests/tst_PrintPage.qml (+1/-1)
ubuntu-printing-app/tests/qmltests/tst_PrintRow.qml (+1/-1)
ubuntu-printing-app/tests/qmltests/tst_SelectorRow.qml (+1/-1)
ubuntu-printing-app/tests/qmltests/tst_TextFieldRow.qml (+1/-1)
ubuntu-printing-app/tests/unittests/backend/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~ahayzen/ubuntu-printing-app/rearrange-folders
Reviewer Review Type Date Requested Status
Michael Sheldon (community) Approve
Review via email: mp+320326@code.launchpad.net

This proposal supersedes a proposal from 2017-03-17.

Commit message

* Move printing app tests into the ubuntu-printing-app folder
* Move backend to ubuntu-printing-app/backend
* Move runner to ubuntu-printing-app/runner
* Remove any trace of click
* Update cmake to respect changes

Description of the change

* Move printing app tests into the ubuntu-printing-app folder
* Move backend to ubuntu-printing-app/backend
* Move runner to ubuntu-printing-app/runner
* Remove any trace of click
* Update cmake to respect changes

To post a comment you must log in.
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Looks good

review: Approve
Revision history for this message
Tanna dietrich (tannaldietrich) wrote :

This is a good post on the app. I have found more info about the app which is applicable for my [url=https://printerssupport.org/ricoh-printer-support/]Ricoh printer[/url]

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2017-03-20 16:30:48 +0000
3+++ CMakeLists.txt 2017-03-20 16:30:48 +0000
4@@ -5,26 +5,11 @@
5 enable_testing()
6
7 # Load translation tools
8-find_program(INTLTOOL_MERGE intltool-merge)
9-if(NOT INTLTOOL_MERGE)
10- message(FATAL_ERROR "Could not find intltool-merge, please install the intltool package")
11-endif()
12-
13-find_program(INTLTOOL_EXTRACT intltool-extract)
14-if(NOT INTLTOOL_EXTRACT)
15- message(FATAL_ERROR "Could not find intltool-extract, please install the intltool package")
16-endif()
17+find_package(Intltool REQUIRED)
18
19 # Set the vars
20-set(APP_NAME ubuntu-printing-app)
21-set(APP_HARDCODE ubuntu-printing-app)
22 set(CMAKE_AUTOMOC ON)
23 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14") # -fno-permissive -pedantic -Wall -Wextra")
24-set(DESKTOP_FILE "${APP_NAME}.desktop")
25-set(ICON_FILE ubuntu-printing-app.svg)
26-set(MAIN_QML Main.qml)
27-set(RUNNER ${APP_HARDCODE})
28-set(SNAP_DESKTOP_FILE setup/gui/${DESKTOP_FILE})
29
30 # Set the options
31 option(SNAP_MODE "Build as a snap package" off)
32@@ -37,44 +22,14 @@
33
34 include(GNUInstallDirs)
35
36-
37-# Set the path for the QML files and the backend
38-set(UBUNTU_PRINTING_APP_DATA_DIR "${CMAKE_INSTALL_DATADIR}/${APP_HARDCODE}")
39-set(MODULE_PATH ${CMAKE_INSTALL_PREFIX}/lib/${CMAKE_LIBRARY_ARCHITECTURE}/${APP_HARDCODE})
40-
41-# Set the exec path
42-if(SNAP_MODE)
43- set(EXEC "APP_ID=${APP_HARDCODE} qmlscene $@ -I $SNAP/${MODULE_PATH} $SNAP/${CMAKE_INSTALL_PREFIX}/${UBUNTU_PRINTING_APP_DATA_DIR}/${MAIN_QML}")
44- set(ICON "$SNAP/${CMAKE_INSTALL_PREFIX}/${UBUNTU_PRINTING_APP_DATA_DIR}/${ICON_FILE}")
45-else(SNAP_MODE)
46- set(EXEC "APP_ID=${APP_HARDCODE} qmlscene $@ -I ${MODULE_PATH} ${CMAKE_INSTALL_PREFIX}/${UBUNTU_PRINTING_APP_DATA_DIR}/${MAIN_QML}")
47- set(ICON ${CMAKE_INSTALL_PREFIX}/${UBUNTU_PRINTING_APP_DATA_DIR}/${ICON_FILE})
48-endif(SNAP_MODE)
49-
50-
51 # Add subdirs
52-add_subdirectory(backend)
53 add_subdirectory(notifier)
54-add_subdirectory(runner)
55 add_subdirectory(ubuntu-printing-app)
56
57 # Setup gettext defs and include po directory
58 set(GETTEXT_PACKAGE "ubuntu-printing-app")
59-add_definitions(-DI18N_DOMAIN="${GETTEXT_PACKAGE}")
60-
61 add_subdirectory(po)
62
63-# Add tests
64-find_package(Qt5Test REQUIRED)
65-enable_testing()
66-add_subdirectory(tests)
67-
68-
69-# Add run command for QtC
70-add_custom_target("run" /usr/bin/qmlscene -I ${CMAKE_BINARY_DIR}/backend ${CMAKE_SOURCE_DIR}/ubuntu-printing-app/Main.qml
71- DEPENDS UbuntuPrintingApp UbuntuPrintingAppqmldir
72- WORKING_DIRECTORY ./ubuntu-printing-app)
73-
74 # Show files in QtC
75 file(GLOB QTC_FILES
76 RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}
77
78=== modified file 'debian/control'
79--- debian/control 2017-03-20 16:30:48 +0000
80+++ debian/control 2017-03-20 16:30:48 +0000
81@@ -3,6 +3,7 @@
82 Priority: optional
83 Maintainer: Andrew Hayzen <andrew.hayzen@canonical.com>
84 Build-Depends: cmake (>= 2.8.9),
85+ cmake-extras (>= 0.10),
86 cmake-extras (>= 1.3),
87 debhelper (>=9),
88 dh-apparmor,
89
90=== modified file 'po/CMakeLists.txt'
91--- po/CMakeLists.txt 2017-01-24 10:58:19 +0000
92+++ po/CMakeLists.txt 2017-03-20 16:30:48 +0000
93@@ -1,44 +1,12 @@
94-project(ubuntu-printing-app-translations)
95-
96-include(FindGettext)
97-find_program(GETTEXT_XGETTEXT_EXECUTABLE xgettext)
98-
99-file(RELATIVE_PATH DESKTOP_FILE_IN_IN ${CMAKE_SOURCE_DIR}
100- ${CMAKE_SOURCE_DIR}/ubuntu-printing-app/${DESKTOP_FILE}.in.in)
101-file(RELATIVE_PATH DESKTOP_FILE_IN_IN_H ${CMAKE_SOURCE_DIR}
102- ${CMAKE_CURRENT_SOURCE_DIR}/${DESKTOP_FILE_IN_IN}.h)
103-
104-file(GLOB_RECURSE I18N_SRC_FILES
105- RELATIVE ${CMAKE_SOURCE_DIR}
106- ${CMAKE_SOURCE_DIR}/ubuntu-printing-app/**.qml)
107-list(SORT I18N_SRC_FILES)
108-
109-set(DOMAIN ${GETTEXT_PACKAGE})
110-set(POT_FILE ${DOMAIN}.pot)
111-file(GLOB PO_FILES *.po)
112-
113-add_custom_target(${POT_FILE} ALL
114- COMMENT "Generating translation template"
115- COMMAND touch ${POT_FILE}
116- COMMAND ${INTLTOOL_EXTRACT} --update --type=gettext/ini
117- --srcdir=${CMAKE_SOURCE_DIR} ${DESKTOP_FILE_IN_IN}
118- COMMAND ${GETTEXT_XGETTEXT_EXECUTABLE} -o ${POT_FILE}
119- -D ${CMAKE_SOURCE_DIR}
120- --from-code=UTF-8
121- --c++ --qt --add-comments=TRANSLATORS
122- --keyword=tr --keyword=tr:1,2 --keyword=N_
123- -j
124- --package-name=ubuntu-printing-app
125- --copyright-holder='Canonical Ltd.'
126- -D ${CMAKE_SOURCE_DIR} ${I18N_SRC_FILES}
127- -D ${CMAKE_BINARY_DIR} ${DESKTOP_FILE_IN_IN_H}
128- COMMAND ${CMAKE_COMMAND} -E copy ${POT_FILE} ${CMAKE_CURRENT_SOURCE_DIR})
129-
130-foreach(PO_FILE ${PO_FILES})
131- get_filename_component(LANG ${PO_FILE} NAME_WE)
132- gettext_process_po_files(${LANG} ALL PO_FILES ${PO_FILE})
133- set(INSTALL_DIR ${CMAKE_INSTALL_LOCALEDIR}/${LANG}/LC_MESSAGES)
134- install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${LANG}.gmo
135- DESTINATION ${INSTALL_DIR}
136- RENAME ${DOMAIN}.mo)
137-endforeach(PO_FILE)
138+intltool_update_potfile(
139+ KEYWORDS "_" "_:1,2" "N_" "N_:1,2" "tr" "tr:1,2"
140+ GETTEXT_PACKAGE ${GETTEXT_PACKAGE}
141+ COPYRIGHT_HOLDER "Canonical Ltd."
142+ FILE_GLOBS "${CMAKE_SOURCE_DIR}/*.desktop.in.in" "${CMAKE_SOURCE_DIR}/*.qml"
143+ FILTER "tests/*"
144+)
145+
146+intltool_install_translations(
147+ ALL
148+ GETTEXT_PACKAGE ${GETTEXT_PACKAGE}
149+)
150
151=== modified file 'po/ubuntu-printing-app.pot'
152--- po/ubuntu-printing-app.pot 2017-02-28 15:34:29 +0000
153+++ po/ubuntu-printing-app.pot 2017-03-20 16:30:48 +0000
154@@ -1,129 +1,198 @@
155 # SOME DESCRIPTIVE TITLE.
156 # Copyright (C) YEAR Canonical Ltd.
157-# This file is distributed under the same license as the ubuntu-printing-app package.
158+# This file is distributed under the same license as the PACKAGE package.
159 # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
160 #
161 #, fuzzy
162 msgid ""
163 msgstr ""
164-"Project-Id-Version: ubuntu-printing-app\n"
165+"Project-Id-Version: PACKAGE VERSION\n"
166 "Report-Msgid-Bugs-To: \n"
167-"POT-Creation-Date: 2017-02-28 15:29+0000\n"
168+"POT-Creation-Date: 2017-03-20 16:29+0000\n"
169 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
170 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
171 "Language-Team: LANGUAGE <LL@li.org>\n"
172 "Language: \n"
173 "MIME-Version: 1.0\n"
174-"Content-Type: text/plain; charset=CHARSET\n"
175+"Content-Type: text/plain; charset=UTF-8\n"
176 "Content-Transfer-Encoding: 8bit\n"
177-
178-#: ubuntu-printing-app/Main.qml:66
179-msgid "Document is invalid"
180-msgstr ""
181-
182-#: ubuntu-printing-app/Main.qml:69
183-msgid "Document not found"
184-msgstr ""
185-
186-#: ubuntu-printing-app/Main.qml:72
187-msgid "Not a PDF document"
188-msgstr ""
189-
190-#: ubuntu-printing-app/Main.qml:75
191-msgid "An unknown error occurred"
192-msgstr ""
193-
194-#: ubuntu-printing-app/Main.qml:99
195-msgid "Error"
196-msgstr ""
197-
198-#: ubuntu-printing-app/Main.qml:126
199-msgid "URL of PDF to print"
200-msgstr ""
201-
202-#: ubuntu-printing-app/components/AlertDialog.qml:28
203+"Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
204+
205+#: ../notifier/src/notify-engine.cpp:48
206+#, c-format
207+msgid "A cover is open on the printer “%s”."
208+msgstr ""
209+
210+#: ../notifier/src/notify-engine.cpp:49
211+#, c-format
212+msgid "The printer “%s” can’t be used, because required software is missing."
213+msgstr ""
214+
215+#: ../notifier/src/notify-engine.cpp:50
216+#, c-format
217+msgid "A door is open on the printer “%s”."
218+msgstr ""
219+
220+#: ../notifier/src/notify-engine.cpp:51
221+#, c-format
222+msgid "The printer “%s” is out of paper."
223+msgstr ""
224+
225+#: ../notifier/src/notify-engine.cpp:52
226+#, c-format
227+msgid "The printer “%s” is low on paper."
228+msgstr ""
229+
230+#: ../notifier/src/notify-engine.cpp:53
231+#, c-format
232+msgid "The printer “%s” is currently off-line."
233+msgstr ""
234+
235+#: ../notifier/src/notify-engine.cpp:54
236+#, c-format
237+msgid "The printer “%s” has an unknown problem."
238+msgstr ""
239+
240+#: ../notifier/src/notify-engine.cpp:55
241+#, c-format
242+msgid "The printer “%s” is out of toner."
243+msgstr ""
244+
245+#: ../notifier/src/notify-engine.cpp:56
246+#, c-format
247+msgid "The printer “%s” is low on toner."
248+msgstr ""
249+
250+#: ../notifier/src/notify-engine.cpp:167
251+#, c-format
252+msgid "“%s” has printed."
253+msgstr ""
254+
255+#: ../notifier/src/notify-engine.cpp:185
256+#, c-format
257+msgid "You have %d job queued to print on this printer."
258+msgid_plural "You have %d jobs queued to print on this printer."
259+msgstr[0] ""
260+msgstr[1] ""
261+
262+#: ../notifier/src/notify-engine.cpp:193
263+#: ../ubuntu-printing-app/components/AlertDialog.qml:28
264 msgid "OK"
265 msgstr ""
266
267-#: ubuntu-printing-app/components/PrintRow.qml:57
268-msgid "Cancel"
269-msgstr ""
270-
271-#: ubuntu-printing-app/components/PrintRow.qml:71
272-msgid "Create PDF"
273-msgstr ""
274-
275-#: ubuntu-printing-app/components/PrintRow.qml:71
276-#: po/ubuntu-printing-app/ubuntu-printing-app.desktop.in.in.h:1
277+#: ../notifier/src/notify-engine.cpp:195
278+msgid "Settings…"
279+msgstr ""
280+
281+#. notifier
282+#. printing
283+#. ubuntu
284+#: ../build/po/ubuntu-printing-app/ubuntu-printing-app.desktop.in.in.h:1
285+#: ../ubuntu-printing-app/ubuntu-printing-app.desktop.in.in.h:1
286+#: ../ubuntu-printing-app/components/PrintRow.qml:74
287 msgid "Print"
288 msgstr ""
289
290-#: ubuntu-printing-app/components/PrintRow.qml:71
291-msgid "Sheets"
292-msgstr ""
293-
294-#: ubuntu-printing-app/pages/ContentPeerPickerPage.qml:43
295-msgid "Open With..."
296-msgstr ""
297-
298-#: ubuntu-printing-app/pages/EmptyPage.qml:48
299+#: ../build/po/ubuntu-printing-app/ubuntu-printing-app.desktop.in.in.h:2
300+#: ../ubuntu-printing-app/ubuntu-printing-app.desktop.in.in.h:2
301+msgid "Print;Printing;"
302+msgstr ""
303+
304+#: ../ubuntu-printing-app/pages/EmptyPage.qml:48
305 msgid ""
306 "No document was chosen for printing. In order to print, you need to select "
307 "print from an app. Alternatively you can export a PDF document from an app."
308 msgstr ""
309
310-#: ubuntu-printing-app/pages/PrintPage.qml:47
311+#: ../ubuntu-printing-app/pages/PrintPage.qml:47
312 msgid "Page Setup"
313 msgstr ""
314
315-#: ubuntu-printing-app/pages/PrintPage.qml:47
316+#: ../ubuntu-printing-app/pages/PrintPage.qml:47
317 msgid "Printer Options"
318 msgstr ""
319
320-#: ubuntu-printing-app/pages/PrintPage.qml:85
321+#: ../ubuntu-printing-app/pages/PrintPage.qml:86
322 msgid "Printer"
323 msgstr ""
324
325-#: ubuntu-printing-app/pages/PrintPage.qml:106
326+#: ../ubuntu-printing-app/pages/PrintPage.qml:107
327 msgid "Copies"
328 msgstr ""
329
330-#: ubuntu-printing-app/pages/PrintPage.qml:129
331-msgid "Collate"
332-msgstr ""
333-
334-#: ubuntu-printing-app/pages/PrintPage.qml:149
335-msgid "Reverse"
336-msgstr ""
337-
338-#: ubuntu-printing-app/pages/PrintPage.qml:170
339+#: ../ubuntu-printing-app/pages/PrintPage.qml:131
340 msgid "All"
341 msgstr ""
342
343-#: ubuntu-printing-app/pages/PrintPage.qml:170
344+#: ../ubuntu-printing-app/pages/PrintPage.qml:131
345 msgid "Range"
346 msgstr ""
347
348-#: ubuntu-printing-app/pages/PrintPage.qml:174
349+#: ../ubuntu-printing-app/pages/PrintPage.qml:135
350 msgid "Pages"
351 msgstr ""
352
353-#: ubuntu-printing-app/pages/PrintPage.qml:216
354+#: ../ubuntu-printing-app/pages/PrintPage.qml:177
355 msgid "eg 1-3,8"
356 msgstr ""
357
358-#: ubuntu-printing-app/pages/PrintPage.qml:225
359+#: ../ubuntu-printing-app/pages/PrintPage.qml:186
360 msgid "Two-sided"
361 msgstr ""
362
363-#: ubuntu-printing-app/pages/PrintPage.qml:246
364+#: ../ubuntu-printing-app/pages/PrintPage.qml:207
365 msgid "Color"
366 msgstr ""
367
368-#: ubuntu-printing-app/pages/PrintPage.qml:267
369+#: ../ubuntu-printing-app/pages/PrintPage.qml:228
370 msgid "Quality"
371 msgstr ""
372
373-#: po/ubuntu-printing-app/ubuntu-printing-app.desktop.in.in.h:2
374-msgid "Print;Printing;"
375+#: ../ubuntu-printing-app/pages/PrintPage.qml:246
376+msgid "Collate"
377+msgstr ""
378+
379+#: ../ubuntu-printing-app/pages/PrintPage.qml:266
380+msgid "Reverse"
381+msgstr ""
382+
383+#: ../ubuntu-printing-app/pages/ContentPeerPickerPage.qml:43
384+msgid "Open With..."
385+msgstr ""
386+
387+#: ../ubuntu-printing-app/Main.qml:66
388+msgid "Document is invalid"
389+msgstr ""
390+
391+#: ../ubuntu-printing-app/Main.qml:69
392+msgid "Document not found"
393+msgstr ""
394+
395+#: ../ubuntu-printing-app/Main.qml:72
396+msgid "Not a PDF document"
397+msgstr ""
398+
399+#: ../ubuntu-printing-app/Main.qml:75
400+msgid "An unknown error occurred"
401+msgstr ""
402+
403+#: ../ubuntu-printing-app/Main.qml:99
404+msgid "Error"
405+msgstr ""
406+
407+#: ../ubuntu-printing-app/Main.qml:126
408+msgid "URL of PDF to print"
409+msgstr ""
410+
411+#. Text color is determined from background color so set from html
412+#: ../ubuntu-printing-app/components/PrintRow.qml:60
413+msgid "Cancel"
414+msgstr ""
415+
416+#: ../ubuntu-printing-app/components/PrintRow.qml:74
417+msgid "Create PDF"
418+msgstr ""
419+
420+#: ../ubuntu-printing-app/components/PrintRow.qml:74
421+msgid "Sheets"
422 msgstr ""
423
424=== removed directory 'setup'
425=== renamed directory 'setup/gui' => 'snap/gui'
426=== renamed file 'snapcraft.yaml' => 'snap/snapcraft.yaml'
427=== modified file 'ubuntu-printing-app/CMakeLists.txt'
428--- ubuntu-printing-app/CMakeLists.txt 2017-01-20 12:36:56 +0000
429+++ ubuntu-printing-app/CMakeLists.txt 2017-03-20 16:30:48 +0000
430@@ -1,6 +1,34 @@
431+set(APP_NAME ubuntu-printing-app)
432+set(APP_HARDCODE ubuntu-printing-app)
433+set(DESKTOP_FILE "${APP_NAME}.desktop")
434+set(ICON_FILE ubuntu-printing-app.svg)
435+set(MAIN_QML Main.qml)
436+set(RUNNER ${APP_HARDCODE})
437+set(SNAP_DESKTOP_FILE snap/gui/${DESKTOP_FILE})
438+
439+# Set the path for the QML files and the backend
440+set(UBUNTU_PRINTING_APP_DATA_DIR "${CMAKE_INSTALL_DATADIR}/${APP_HARDCODE}")
441+set(MODULE_PATH ${CMAKE_INSTALL_PREFIX}/lib/${CMAKE_LIBRARY_ARCHITECTURE}/${APP_HARDCODE})
442+
443+# Set the exec path
444+if(SNAP_MODE)
445+ set(EXEC "APP_ID=${APP_HARDCODE} qmlscene $@ -I $SNAP/${MODULE_PATH} $SNAP/${CMAKE_INSTALL_PREFIX}/${UBUNTU_PRINTING_APP_DATA_DIR}/${MAIN_QML}")
446+ set(ICON "$SNAP/${CMAKE_INSTALL_PREFIX}/${UBUNTU_PRINTING_APP_DATA_DIR}/${ICON_FILE}")
447+else(SNAP_MODE)
448+ set(EXEC "APP_ID=${APP_HARDCODE} qmlscene $@ -I ${MODULE_PATH} ${CMAKE_INSTALL_PREFIX}/${UBUNTU_PRINTING_APP_DATA_DIR}/${MAIN_QML}")
449+ set(ICON ${CMAKE_INSTALL_PREFIX}/${UBUNTU_PRINTING_APP_DATA_DIR}/${ICON_FILE})
450+endif(SNAP_MODE)
451+
452+add_subdirectory(backend)
453 add_subdirectory(components)
454+add_subdirectory(runner)
455 add_subdirectory(pages)
456
457+# Add tests
458+find_package(Qt5Test REQUIRED)
459+enable_testing()
460+add_subdirectory(tests)
461+
462 # Install Main.qml and icon
463 install(FILES ${MAIN_QML} DESTINATION ${UBUNTU_PRINTING_APP_DATA_DIR})
464 install(FILES ${ICON_FILE} DESTINATION ${UBUNTU_PRINTING_APP_DATA_DIR})
465@@ -12,10 +40,11 @@
466
467 # Install desktop file
468 configure_file(${CMAKE_CURRENT_SOURCE_DIR}/${DESKTOP_FILE}.in.in ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}.in)
469-
470-add_custom_target(${DESKTOP_FILE} ALL
471- COMMENT "Merging translations into ${DESKTOP_FILE}"
472- COMMAND LC_ALL=C ${INTLTOOL_MERGE} -d -u ${CMAKE_SOURCE_DIR}/po ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}.in ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}
473+intltool_merge_translations(
474+ "${DESKTOP_FILE}.in"
475+ "${DESKTOP_FILE}"
476+ ALL
477+ UTF8
478 )
479
480 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}
481@@ -27,3 +56,6 @@
482 file(GLOB MAIN_QML_JS_FILES *.apparmor *.js *.json *.qml)
483 add_custom_target(ubuntu_printing_app_main_qml_js_files ALL SOURCES ${MAIN_QML_JS_FILES})
484 endif(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
485+
486+# Set variables for use in parent scope
487+set(UBUNTU_PRINTING_APP_DESKTOP_FILE "${DESKTOP_FILE}" PARENT_SCOPE)
488
489=== renamed directory 'backend' => 'ubuntu-printing-app/backend'
490=== renamed directory 'runner' => 'ubuntu-printing-app/runner'
491=== renamed directory 'tests' => 'ubuntu-printing-app/tests'
492=== modified file 'ubuntu-printing-app/tests/qmltests/CMakeLists.txt'
493--- tests/qmltests/CMakeLists.txt 2017-03-07 14:53:12 +0000
494+++ ubuntu-printing-app/tests/qmltests/CMakeLists.txt 2017-03-20 16:30:48 +0000
495@@ -18,7 +18,7 @@
496 set(TEST tst_QmlTests)
497 add_test(${TEST} ${XVFB_COMMAND} ${QMLTESTRUNNER} -qt=qt5
498 -input ${CMAKE_CURRENT_SOURCE_DIR}
499- -import ${CMAKE_BINARY_DIR}/backend)
500+ -import ${CMAKE_BINARY_DIR}/ubuntu-printing-app/backend)
501
502
503 # Add the qml test files to build dir
504
505=== modified file 'ubuntu-printing-app/tests/qmltests/tst_CheckBoxRow.qml'
506--- tests/qmltests/tst_CheckBoxRow.qml 2017-01-25 18:13:57 +0000
507+++ ubuntu-printing-app/tests/qmltests/tst_CheckBoxRow.qml 2017-03-20 16:30:48 +0000
508@@ -20,7 +20,7 @@
509 import QtQuick 2.4
510 import QtTest 1.1
511 import Ubuntu.Test 1.0
512-import "../../ubuntu-printing-app/components"
513+import "../../components"
514
515 Item {
516 width: units.gu(100)
517
518=== modified file 'ubuntu-printing-app/tests/qmltests/tst_LabelRow.qml'
519--- tests/qmltests/tst_LabelRow.qml 2017-01-25 12:45:05 +0000
520+++ ubuntu-printing-app/tests/qmltests/tst_LabelRow.qml 2017-03-20 16:30:48 +0000
521@@ -20,7 +20,7 @@
522 import QtQuick 2.4
523 import QtTest 1.1
524 import Ubuntu.Test 1.0
525-import "../../ubuntu-printing-app/components"
526+import "../../components"
527
528 Item {
529 width: units.gu(100)
530
531=== modified file 'ubuntu-printing-app/tests/qmltests/tst_PreviewRow.qml'
532--- tests/qmltests/tst_PreviewRow.qml 2017-03-08 12:59:51 +0000
533+++ ubuntu-printing-app/tests/qmltests/tst_PreviewRow.qml 2017-03-20 16:30:48 +0000
534@@ -20,7 +20,7 @@
535 import QtQuick 2.4
536 import QtTest 1.1
537 import Ubuntu.Test 1.0
538-import "../../ubuntu-printing-app/components"
539+import "../../components"
540
541 import UbuntuPrintingApp 1.0
542 import Ubuntu.Components.Extras.Printers 0.1
543
544=== modified file 'ubuntu-printing-app/tests/qmltests/tst_PrintPage.qml'
545--- tests/qmltests/tst_PrintPage.qml 2017-03-08 12:59:51 +0000
546+++ ubuntu-printing-app/tests/qmltests/tst_PrintPage.qml 2017-03-20 16:30:48 +0000
547@@ -20,7 +20,7 @@
548 import QtQuick 2.4
549 import QtTest 1.1
550 import Ubuntu.Test 1.0
551-import "../../ubuntu-printing-app/pages"
552+import "../../pages"
553
554 import UbuntuPrintingApp 1.0
555 import Ubuntu.Components.Extras.Printers 0.1
556
557=== modified file 'ubuntu-printing-app/tests/qmltests/tst_PrintRow.qml'
558--- tests/qmltests/tst_PrintRow.qml 2017-02-17 17:48:28 +0000
559+++ ubuntu-printing-app/tests/qmltests/tst_PrintRow.qml 2017-03-20 16:30:48 +0000
560@@ -20,7 +20,7 @@
561 import QtQuick 2.4
562 import QtTest 1.1
563 import Ubuntu.Test 1.0
564-import "../../ubuntu-printing-app/components"
565+import "../../components"
566
567 Item {
568 width: units.gu(100)
569
570=== modified file 'ubuntu-printing-app/tests/qmltests/tst_SelectorRow.qml'
571--- tests/qmltests/tst_SelectorRow.qml 2017-03-07 13:46:02 +0000
572+++ ubuntu-printing-app/tests/qmltests/tst_SelectorRow.qml 2017-03-20 16:30:48 +0000
573@@ -20,7 +20,7 @@
574 import QtQuick 2.4
575 import QtTest 1.1
576 import Ubuntu.Test 1.0
577-import "../../ubuntu-printing-app/components"
578+import "../../components"
579
580 Item {
581 width: units.gu(100)
582
583=== modified file 'ubuntu-printing-app/tests/qmltests/tst_TextFieldRow.qml'
584--- tests/qmltests/tst_TextFieldRow.qml 2017-01-25 12:45:05 +0000
585+++ ubuntu-printing-app/tests/qmltests/tst_TextFieldRow.qml 2017-03-20 16:30:48 +0000
586@@ -20,7 +20,7 @@
587 import QtQuick 2.4
588 import QtTest 1.1
589 import Ubuntu.Test 1.0
590-import "../../ubuntu-printing-app/components"
591+import "../../components"
592
593 Item {
594 width: units.gu(100)
595
596=== modified file 'ubuntu-printing-app/tests/unittests/backend/CMakeLists.txt'
597--- tests/unittests/backend/CMakeLists.txt 2017-01-27 17:17:01 +0000
598+++ ubuntu-printing-app/tests/unittests/backend/CMakeLists.txt 2017-03-20 16:30:48 +0000
599@@ -1,7 +1,7 @@
600 include_directories(
601 ${CMAKE_CURRENT_SOURCE_DIR}
602 ${CMAKE_CURRENT_BINARY_DIR}
603- ${CMAKE_SOURCE_DIR}/backend/
604+ ${CMAKE_SOURCE_DIR}/ubuntu-printing-app/backend/
605 )
606
607 find_package(Qt5Test REQUIRED)

Subscribers

People subscribed via source and target branches

to all changes: