lp:~ahayzen/ubuntu-printing-app/page-range-validate-and-count

Branch merges

Propose for merging

No branches dependent on this one.

Approved for merging into lp:ubuntu-printing-app

Michael Sheldon (community): Approve on 2017-04-05

Diff: 918 lines (+666/-36)

11 files modified

po/ubuntu-printing-app.pot (+25/-9)
ubuntu-printing-app/backend/CMakeLists.txt (+2/-1)
ubuntu-printing-app/backend/UbuntuPrintingApp/backend.cpp (+2/-0)
ubuntu-printing-app/backend/UbuntuPrintingApp/pagerangevalidator.cpp (+192/-0)
ubuntu-printing-app/backend/UbuntuPrintingApp/pagerangevalidator.h (+75/-0)
ubuntu-printing-app/components/LabelRow.qml (+2/-0)
ubuntu-printing-app/pages/PrintPage.qml (+53/-21)
ubuntu-printing-app/tests/qmltests/tst_LabelRow.qml (+8/-0)
ubuntu-printing-app/tests/qmltests/tst_PrintPage.qml (+152/-5)
ubuntu-printing-app/tests/unittests/backend/CMakeLists.txt (+4/-0)
ubuntu-printing-app/tests/unittests/backend/tst_pagerangevalidator.cpp (+151/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

73. By Andrew Hayzen on 2017-04-05

* Set Qt.ImhPreferNumbers for page-ranges text field

72. By Andrew Hayzen on 2017-04-05

* Remove unneeded TODO

71. By Andrew Hayzen on 2017-04-05

* Ensure NoError state is always set
* Update naming of error for 5-3

70. By Andrew Hayzen on 2017-03-31

* Rebase onto lp:ubuntu-printing-app

69. By Andrew Hayzen on 2017-03-31

* Add validation to copies field with tests

68. By Andrew Hayzen on 2017-03-30

* Add page range validation and counting with tests

67. By Andrew Hayzen on 2017-03-21

* Be explicit in the comparision

66. By Andrew Hayzen on 2017-03-21

* Only show sheets count in print button when we are not performing a print range for now.
* Fix sheets text so that it shows singular and plural

65. By Andrew Hayzen on 2017-03-21

* Increase section label size

64. By Andrew Hayzen on 2017-03-21

* Fix translation issues