ubuntu-printing-app

Merge lp:~ahayzen/ubuntu-printing-app/fix-notifier-url into lp:ubuntu-printing-app

  1. fix-notifier-url
  2. Merge into trunk
Proposed by Andrew Hayzen
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 68
Merged at revision: 37
Proposed branch: lp:~ahayzen/ubuntu-printing-app/fix-notifier-url
Merge into: lp:ubuntu-printing-app
Prerequisite: lp:~ahayzen/ubuntu-printing-app/page-range-ignore-sheets-count
Diff against target: 11 lines (+1/-1)
1 file modified
notifier/src/notify-engine.cpp (+1/-1)
To merge this branch: bzr merge lp:~ahayzen/ubuntu-printing-app/fix-notifier-url
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
Review via email: mp+320792@code.launchpad.net

Commit message

* Fix notifier system-settings url

Description of the change

* Fix notifier system-settings url

To post a comment you must log in.
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

USS will guarantee that this will always work. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'notifier/src/notify-engine.cpp'
2--- notifier/src/notify-engine.cpp 2017-03-23 12:36:41 +0000
3+++ notifier/src/notify-engine.cpp 2017-03-23 12:36:41 +0000
4@@ -191,7 +191,7 @@
5
6 notification->set_hint(NOTIFY_HINT_SNAP, "true");
7 notification->add_action("PRINTER_ACTION_IGNORE", _("OK"));
8- std::string settings_url{"settings:///system/printers/"};
9+ std::string settings_url{"settings:///system/view-printer?name="};
10 notification->add_action(settings_url + printer.name, _("Settings…"));
11 }
12

Subscribers

People subscribed via source and target branches

to all changes: