Merge lp:~ahayzen/ubuntu-calendar-app/fix-1423191-no-future-events into lp:ubuntu-calendar-app

Proposed by Andrew Hayzen
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 582
Merged at revision: 583
Proposed branch: lp:~ahayzen/ubuntu-calendar-app/fix-1423191-no-future-events
Merge into: lp:ubuntu-calendar-app
Diff against target: 11 lines (+1/-1)
1 file modified
AgendaView.qml (+1/-1)
To merge this branch: bzr merge lp:~ahayzen/ubuntu-calendar-app/fix-1423191-no-future-events
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Kunal Parmar Approve
Review via email: mp+250188@code.launchpad.net

Commit message

* Fix to not show the "No future events" label if the model is loading

Description of the change

* Fix to not show the "No future events" label if the model is loading

To post a comment you must log in.
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

looks good to me

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'AgendaView.qml'
2--- AgendaView.qml 2014-11-11 15:16:12 +0000
3+++ AgendaView.qml 2015-02-18 19:11:25 +0000
4@@ -96,7 +96,7 @@
5
6 return default_title;
7 }
8- visible: !root.hasEnabledCalendars() || !eventListModel.itemCount
9+ visible: (!root.hasEnabledCalendars() || !eventListModel.itemCount) && !eventListModel.isLoading
10 anchors.centerIn: parent
11 }
12

Subscribers

People subscribed via source and target branches

to status/vote changes: