qtubuntu-media

Merge lp:~ahayzen/qtubuntu-media/fix-1531296-random-mode-repeat-for-now into lp:qtubuntu-media

  1. fix-1531296-random-mode-repeat-for-now
  2. Merge into trunk
Proposed by Andrew Hayzen
Status: Merged
Approved by: Jim Hodapp
Approved revision: 96
Merged at revision: 97
Proposed branch: lp:~ahayzen/qtubuntu-media/fix-1531296-random-mode-repeat-for-now
Merge into: lp:qtubuntu-media
Diff against target: 13 lines (+3/-0)
1 file modified
src/aal/aalmediaplaylistcontrol.cpp (+3/-0)
To merge this branch: bzr merge lp:~ahayzen/qtubuntu-media/fix-1531296-random-mode-repeat-for-now
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+282323@code.launchpad.net

This proposal supersedes a proposal from 2016-01-05.

Commit message

* Until bug 1518157 (RandomAndLoop playbackMode) is fixed set Random to be always looping due to bug 1531296

Description of the change

* Until bug 1518157 (RandomAndLoop playbackMode) is fixed set Random to be always looping due to bug 1531296

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote : Posted in a previous version of this proposal

Looks good as a work around for making sure music-app doesn't have a regression from the way it works when it implemented playlists. This is a temporary fix until we decide how to solve the lack of this mode being possible with QtMultimedia's API.

review: Approve (code)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:96
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/136/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/61
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/61
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/61/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/61

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/136/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)
lp:~ahayzen/qtubuntu-media/fix-1531296-random-mode-repeat-for-now updated
97. By Andrew Hayzen

* Merge of lp:qtubuntu-media

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/aal/aalmediaplaylistcontrol.cpp'
2--- src/aal/aalmediaplaylistcontrol.cpp 2016-01-07 14:10:19 +0000
3+++ src/aal/aalmediaplaylistcontrol.cpp 2016-01-13 16:45:41 +0000
4@@ -232,6 +232,9 @@
5 case QMediaPlaylist::Random:
6 qDebug() << "PlaybackMode: Random";
7 m_hubPlayerSession->shuffle() = true;
8+ // FIXME: Until pad.lv/1518157 (RandomAndLoop playbackMode) is
9+ // fixed set Random to be always looping due to pad.lv/1531296
10+ m_hubPlayerSession->loop_status() = media::Player::LoopStatus::playlist;
11 break;
12 default:
13 qWarning() << "Unknown playback mode: " << mode;

Subscribers

People subscribed via source and target branches