Merge lp:~ahayzen/qtubuntu-media/fix-1510225-isReadOnly-not-respecting-canEditTracks into lp:qtubuntu-media

[Andrew Hayzen]

* Fix isReadOnly to respect can_edit_tracks correctly, so when can_edit_tracks is True isReadOnly is False

* Fix isReadOnly to respect can_edit_tracks correctly, so when can_edit_tracks is True isReadOnly is False

This should be tested using the silo 1972 [0] and the music-app which enables load/save support [1] (you should notice a m3u file here /home/phablet/.local/share/com.ubuntu.music/queue.m3u).

0 - https://requests.ci-train.ubuntu.com/#/ticket/1972
1 - https://code.launchpad.net/~ahayzen/music-app/fix-1510225-use-save-load-playlist

[Jim Hodapp (jhodapp)]

LGTM

review: Approve (code)

=== modified file 'src/aal/aalmediaplaylistprovider.cpp'
--- src/aal/aalmediaplaylistprovider.cpp	2016-07-20 21:26:54 +0000
+++ src/aal/aalmediaplaylistprovider.cpp	2016-09-27 09:51:58 +0000
@@ -89,7 +89,7 @@
     }
 
     try {
-        return m_hubTrackList->can_edit_tracks();
+        return !m_hubTrackList->can_edit_tracks();
     }
     catch (const std::runtime_error &e) {
         qWarning() << "Failed to see if tracklist is editable: " << e.what();