Ubuntu Music App

Merge lp:~ahayzen/music-app/walkthrough-max-width into lp:music-app/remix

  1. walkthrough-max-width
  2. Merge into remix
Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 804
Merged at revision: 803
Proposed branch: lp:~ahayzen/music-app/walkthrough-max-width
Merge into: lp:music-app/remix
Diff against target: 123 lines (+15/-6)
5 files modified
common/Walkthrough/Slide1.qml (+3/-1)
common/Walkthrough/Slide2.qml (+3/-1)
common/Walkthrough/Slide3.qml (+3/-1)
common/Walkthrough/Walkthrough.qml (+5/-2)
music-app.qml (+1/-1)
To merge this branch: bzr merge lp:~ahayzen/music-app/walkthrough-max-width
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Victor Thompson Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+247145@code.launchpad.net

Commit message

* Ensure that walkthrough slides have a max width so that they are consistent with empty states

Description of the change

* Ensure that walkthrough slides have a max width so that they are consistent with empty states

When testing on larger devices, eg the Nexus 7, it was found that the walkthrough does not have a maximum width so the labels can span [0] [1] [2] but the empty states have a maximum width which causes the labels to wrap [3]. This mp ensures that the widths of the empty states/walkthroughs are consistent.

0 - http://popey.mooo.com/screenshots/device-2015-01-21-123249.png
1 - http://popey.mooo.com/screenshots/device-2015-01-21-123342.png
2 - http://popey.mooo.com/screenshots/device-2015-01-21-123330.png
3 - http://popey.mooo.com/screenshots/device-2015-01-21-123424.png

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Looks good..

13:40 <popey> http://popey.mooo.com/screenshots/device-2015-01-21-133806.png
13:40 <popey> http://popey.mooo.com/screenshots/device-2015-01-21-133816.png
13:40 <popey> http://popey.mooo.com/screenshots/device-2015-01-21-133824.png
13:40 <popey> http://popey.mooo.com/screenshots/device-2015-01-21-133832.png

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:801
http://91.189.93.70:8080/job/music-app-ci/1251/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/771
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/771/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/103

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1251/rebuild

review: Approve (continuous-integration)
lp:~ahayzen/music-app/walkthrough-max-width updated
802. By Andrew Hayzen

* Merge of trunk

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:802
http://91.189.93.70:8080/job/music-app-ci/1253/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/774
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/774/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/105

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1253/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

In order to match the visual mockups a few things need to be fixed:

1. In general there needs to be more space between the images and the title text. The title and body text. The text should be more than half way down the screen. This is the reason I had it anchored to the bottom of the screen. Perhaps we can fix this by making the spacing value a % of the window height?
2. Similar to the above, the "Start" button should be far closer to the bottom of the screen. Looking at it now, even my tweak might not have put it close enough to the bottom to match the design spec.

review: Needs Fixing
lp:~ahayzen/music-app/walkthrough-max-width updated
803. By Andrew Hayzen

* Change walkthrough spacing

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:803
http://91.189.93.70:8080/job/music-app-ci/1255/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/793
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/793/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/107

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1255/rebuild

review: Approve (continuous-integration)
lp:~ahayzen/music-app/walkthrough-max-width updated
804. By Andrew Hayzen

* Revert using Column in sliders

Revision history for this message
Victor Thompson (vthompson) wrote :

LGTM! The walkthrough now has similar width to the empty states and looks pleasing on a wider screen. Thanks!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:804
http://91.189.93.70:8080/job/music-app-ci/1256/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/796
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/796/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/108

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1256/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'common/Walkthrough/Slide1.qml'
2--- common/Walkthrough/Slide1.qml 2015-01-20 05:05:57 +0000
3+++ common/Walkthrough/Slide1.qml 2015-01-22 01:04:43 +0000
4@@ -1,5 +1,6 @@
5 /*
6 * Copyright (C) 2014-2015
7+ * Andrew Hayzen <ahayzen@gmail.com>
8 * Nekhelesh Ramananthan <nik90@ubuntu.com>
9 * Victor Thompson <victor.thompson@gmail.com>
10 *
11@@ -54,6 +55,7 @@
12 height: contentHeight
13 horizontalAlignment: Text.AlignHLeft
14 text: i18n.tr("Welcome to Music")
15+ width: units.gu(36)
16 }
17
18 Label {
19@@ -66,7 +68,7 @@
20 height: contentHeight
21 horizontalAlignment: Text.AlignHLeft
22 text: i18n.tr("Enjoy your favorite music with Ubuntu's Music App. Take a short tour on how to get started or press skip to start listening now.")
23- width: parent.width
24+ width: units.gu(36)
25 wrapMode: Text.WordWrap
26 }
27 }
28
29=== modified file 'common/Walkthrough/Slide2.qml'
30--- common/Walkthrough/Slide2.qml 2015-01-21 00:40:26 +0000
31+++ common/Walkthrough/Slide2.qml 2015-01-22 01:04:43 +0000
32@@ -1,5 +1,6 @@
33 /*
34 * Copyright (C) 2014-2015
35+ * Andrew Hayzen <ahayzen@gmail.com>
36 * Nekhelesh Ramananthan <nik90@ubuntu.com>
37 * Victor Thompson <victor.thompson@gmail.com>
38 *
39@@ -49,6 +50,7 @@
40 fontSize: "x-large"
41 horizontalAlignment: Text.AlignHLeft
42 text: i18n.tr("Import your music")
43+ width: units.gu(36)
44 }
45
46 Label {
47@@ -60,7 +62,7 @@
48 fontSize: "large"
49 horizontalAlignment: Text.AlignHLeft
50 text: i18n.tr("Connect your device to any computer and simply drag files to the Music folder or insert removable media with music.")
51- width: parent.width
52+ width: units.gu(36)
53 wrapMode: Text.WordWrap
54 }
55 }
56
57=== modified file 'common/Walkthrough/Slide3.qml'
58--- common/Walkthrough/Slide3.qml 2015-01-21 14:05:44 +0000
59+++ common/Walkthrough/Slide3.qml 2015-01-22 01:04:43 +0000
60@@ -1,5 +1,6 @@
61 /*
62 * Copyright (C) 2014-2015
63+ * Andrew Hayzen <ahayzen@gmail.com>
64 * Nekhelesh Ramananthan <nik90@ubuntu.com>
65 * Victor Thompson <victor.thompson@gmail.com>
66 *
67@@ -49,6 +50,7 @@
68 fontSize: "x-large"
69 horizontalAlignment: Text.AlignHLeft
70 text: i18n.tr("Download new music")
71+ width: units.gu(36)
72 }
73
74 Label {
75@@ -60,7 +62,7 @@
76 fontSize: "large"
77 horizontalAlignment: Text.AlignHLeft
78 text: i18n.tr("Directly import music bought while browsing online.")
79- width: parent.width
80+ width: units.gu(36)
81 wrapMode: Text.WordWrap
82 }
83
84
85=== modified file 'common/Walkthrough/Walkthrough.qml'
86--- common/Walkthrough/Walkthrough.qml 2015-01-21 14:05:44 +0000
87+++ common/Walkthrough/Walkthrough.qml 2015-01-22 01:04:43 +0000
88@@ -1,5 +1,6 @@
89 /*
90 * Copyright (C) 2014-2015
91+ * Andrew Hayzen <ahayzen@gmail.com>
92 * Nekhelesh Ramananthan <nik90@ubuntu.com>
93 * Victor Thompson <victor.thompson@gmail.com>
94 *
95@@ -62,11 +63,13 @@
96
97 Loader {
98 anchors {
99- fill: parent
100+ bottom: parent.bottom
101+ horizontalCenter: parent.horizontalCenter
102 margins: units.gu(2)
103+ top: parent.top
104 }
105-
106 sourceComponent: modelData
107+ width: units.gu(36)
108 }
109 }
110 }
111
112=== modified file 'music-app.qml'
113--- music-app.qml 2015-01-21 01:16:38 +0000
114+++ music-app.qml 2015-01-22 01:04:43 +0000
115@@ -1323,7 +1323,7 @@
116 centerIn: parent
117 }
118 spacing: units.gu(4)
119- width: units.gu(35)
120+ width: units.gu(36)
121
122 Row {
123 anchors {

Subscribers

People subscribed via source and target branches