Code review comment for lp:~ahayzen/music-app/search-toolbar-item

Revision history for this message
Victor Thompson (vthompson) wrote :

We should try to detect the 14.10 SDK vs the 14.04 SDK via 'header.useDepcrecatedToolbar' or similar, as we had done previously. Perhaps we should use this to create a 'useUtopicSDK' so the code that depends on these switches makes more sense. That way we can hide the toolbar's search button that shows up on the desktop/tablet.

I think, overall, we should wait until this lands in the Utopic images before we land this so we can test it on the device without setting up a PPA or testing via a silo.

« Back to merge proposal