Merge lp:~ahayzen/music-app/remix-sort-playlists into lp:music-app/remix

Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 716
Merged at revision: 715
Proposed branch: lp:~ahayzen/music-app/remix-sort-playlists
Merge into: lp:music-app/remix
Diff against target: 12 lines (+1/-1)
1 file modified
playlists.js (+1/-1)
To merge this branch: bzr merge lp:~ahayzen/music-app/remix-sort-playlists
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Victor Thompson Approve
Review via email: mp+239893@code.launchpad.net

Commit message

* Sort playlists by name

Description of the change

* Sort playlists by name

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
715. By Andrew Hayzen

* Merge of lp:music-app/remix

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

There maybe some instances where the list isn't filtered when it should be, but this works well. Thanks!

review: Approve
Revision history for this message
Victor Thompson (vthompson) wrote :

Actually, could we add "COLLATE NOCASE" so this gets sorted so case doesn't matter? Right now it is sorted ]A-Za-z]

review: Needs Fixing
716. By Andrew Hayzen

* Make case insensitive

Revision history for this message
Victor Thompson (vthompson) wrote :

LGTM! Thanks!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'playlists.js'
2--- playlists.js 2014-10-22 20:46:01 +0000
3+++ playlists.js 2014-10-29 00:46:30 +0000
4@@ -180,7 +180,7 @@
5
6 try {
7 db.transaction(function (tx) {
8- var rs = tx.executeSql('SELECT * FROM playlist;')
9+ var rs = tx.executeSql('SELECT * FROM playlist ORDER BY name COLLATE NOCASE;')
10
11 for (var i = 0; i < rs.rows.length; i++) {
12 var dbItem = rs.rows.item(i)

Subscribers

People subscribed via source and target branches