Merge lp:~ahayzen/music-app/remix-remove-empty-year-label into lp:music-app/remix

Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 683
Merged at revision: 685
Proposed branch: lp:~ahayzen/music-app/remix-remove-empty-year-label
Merge into: lp:music-app/remix
Diff against target: 15 lines (+3/-2)
1 file modified
common/SongsPage.qml (+3/-2)
To merge this branch: bzr merge lp:~ahayzen/music-app/remix-remove-empty-year-label
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Victor Thompson Approve
Review via email: mp+239106@code.launchpad.net

Commit message

* Only show year in SongsPage.qml if year exists

Description of the change

* Only show year in SongsPage.qml if year exists

To post a comment you must log in.
683. By Andrew Hayzen

* Fix formatting

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

LGTM!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'common/SongsPage.qml'
2--- common/SongsPage.qml 2014-10-20 14:14:09 +0000
3+++ common/SongsPage.qml 2014-10-21 17:32:18 +0000
4@@ -225,8 +225,9 @@
5 elide: Text.ElideRight
6 fontSize: "small"
7 maximumLineCount: 1
8- text: isAlbum && line1 !== i18n.tr("Genre") ? year + " | " + i18n.tr("%1 song", "%1 songs", albumtrackslist.count).arg(albumtrackslist.count)
9- : i18n.tr("%1 song", "%1 songs", albumtrackslist.count).arg(albumtrackslist.count)
10+ text: isAlbum && line1 !== i18n.tr("Genre")
11+ ? (year !== "" ? year + " | " : "") + i18n.tr("%1 song", "%1 songs", albumtrackslist.count).arg(albumtrackslist.count)
12+ : i18n.tr("%1 song", "%1 songs", albumtrackslist.count).arg(albumtrackslist.count)
13 wrapMode: Text.NoWrap
14 }
15 }

Subscribers

People subscribed via source and target branches