Merge lp:~ahayzen/music-app/remix-queue-add-to-playlist into lp:music-app/remix

Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 696
Merged at revision: 694
Proposed branch: lp:~ahayzen/music-app/remix-queue-add-to-playlist
Merge into: lp:music-app/remix
Diff against target: 588 lines (+138/-212)
2 files modified
MusicNowPlaying.qml (+26/-8)
po/com.ubuntu.music.pot (+112/-204)
To merge this branch: bzr merge lp:~ahayzen/music-app/remix-queue-add-to-playlist
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Victor Thompson Approve
Review via email: mp+239253@code.launchpad.net

Commit message

* Add save to playlist action
* Only enable actions in now playing when trackQueue count > 0

Description of the change

* Add save to playlist action
* Only enable actions in now playing when trackQueue count > 0

To post a comment you must log in.
696. By Andrew Hayzen

* Update .pot

Revision history for this message
Victor Thompson (vthompson) wrote :

LGTM! :)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicNowPlaying.qml'
2--- MusicNowPlaying.qml 2014-10-22 16:03:45 +0000
3+++ MusicNowPlaying.qml 2014-10-22 18:24:47 +0000
4@@ -64,20 +64,38 @@
5 }
6 actions: [
7 Action {
8+ objectName: "toggleView"
9+ iconName: "media-playlist"
10+ onTriggered: {
11+ isListView = !isListView
12+ }
13+ },
14+ Action {
15+ enabled: trackQueue.model.count > 0
16+ iconName: "add-to-playlist"
17+ text: i18n.tr("Add to playlist")
18+ visible: isListView
19+ onTriggered: {
20+ var items = []
21+
22+ for (var i=0; i < trackQueue.model.count; i++) {
23+ items.push(makeDict(trackQueue.model.get(i)));
24+ }
25+
26+ chosenElements = items;
27+ mainPageStack.push(addtoPlaylist)
28+ }
29+ },
30+ Action {
31+ enabled: trackQueue.model.count > 0
32+ iconName: "delete"
33 objectName: "clearQueue"
34- iconName: "delete"
35+ text: i18n.tr("Clear queue")
36 visible: isListView
37 onTriggered: {
38 head.backAction.trigger()
39 trackQueue.model.clear()
40 }
41- },
42- Action {
43- objectName: "toggleView"
44- iconName: "media-playlist"
45- onTriggered: {
46- isListView = !isListView
47- }
48 }
49 ]
50 PropertyChanges {
51
52=== modified file 'po/com.ubuntu.music.pot'
53--- po/com.ubuntu.music.pot 2014-10-20 14:10:36 +0000
54+++ po/com.ubuntu.music.pot 2014-10-22 18:24:47 +0000
55@@ -8,7 +8,7 @@
56 msgstr ""
57 "Project-Id-Version: music-app\n"
58 "Report-Msgid-Bugs-To: \n"
59-"POT-Creation-Date: 2014-10-20 15:09+0100\n"
60+"POT-Creation-Date: 2014-10-22 19:22+0100\n"
61 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
62 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
63 "Language-Team: LANGUAGE <LL@li.org>\n"
64@@ -18,42 +18,6 @@
65 "Content-Transfer-Encoding: 8bit\n"
66 "Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
67
68-#: ../LoginLastFM.qml:48 ../MusicSettings.qml:134 ../MusicSettings.qml:142
69-msgid "Last.fm"
70-msgstr ""
71-
72-#: ../LoginLastFM.qml:54
73-msgid "Login to be able to scrobble."
74-msgstr ""
75-
76-#: ../LoginLastFM.qml:62
77-msgid "Username"
78-msgstr ""
79-
80-#: ../LoginLastFM.qml:72
81-msgid "Password"
82-msgstr ""
83-
84-#: ../LoginLastFM.qml:94
85-msgid "Login"
86-msgstr ""
87-
88-#: ../LoginLastFM.qml:101
89-msgid "Trying to login..."
90-msgstr ""
91-
92-#: ../LoginLastFM.qml:115
93-msgid "Login Successful"
94-msgstr ""
95-
96-#: ../LoginLastFM.qml:121
97-msgid "Login Failed"
98-msgstr ""
99-
100-#: ../LoginLastFM.qml:127
101-msgid "You forgot to set your username and/or password"
102-msgstr ""
103-
104 #: ../MusicAlbums.qml:29
105 msgid "Albums"
106 msgstr ""
107@@ -62,14 +26,25 @@
108 msgid "Album"
109 msgstr ""
110
111-#: ../MusicArtists.qml:37
112+#: ../MusicArtists.qml:36
113 msgid "Artists"
114 msgstr ""
115
116-#: ../MusicArtists.qml:78
117+#: ../MusicArtists.qml:77
118 msgid "Artist"
119 msgstr ""
120
121+#: ../MusicGenres.qml:29
122+msgid "Genres"
123+msgstr ""
124+
125+#: ../MusicGenres.qml:89 ../MusicGenres.qml:91 ../common/SongsPage.qml:223
126+#: ../common/SongsPage.qml:261 ../common/SongsPage.qml:274
127+#: ../common/SongsPage.qml:310 ../common/SongsPage.qml:329
128+#: ../common/SongsPage.qml:361
129+msgid "Genre"
130+msgstr ""
131+
132 #: ../MusicNowPlaying.qml:33
133 msgid "Queue"
134 msgstr ""
135@@ -78,14 +53,35 @@
136 msgid "Now playing"
137 msgstr ""
138
139+#: ../MusicNowPlaying.qml:76 ../MusicNowPlaying.qml:131 ../MusicTracks.qml:61
140+#: ../common/ListItemActions/AddToPlaylist.qml:25 ../common/SongsPage.qml:108
141+msgid "Add to playlist"
142+msgstr ""
143+
144+#: ../MusicNowPlaying.qml:93
145+msgid "Clear queue"
146+msgstr ""
147+
148+#: ../MusicNowPlaying.qml:112 ../MusicTracks.qml:42 ../common/SongsPage.qml:89
149+msgid "Cancel selection"
150+msgstr ""
151+
152+#: ../MusicNowPlaying.qml:118 ../MusicTracks.qml:49 ../common/SongsPage.qml:96
153+msgid "Select All"
154+msgstr ""
155+
156+#: ../MusicNowPlaying.qml:148 ../common/SongsPage.qml:137
157+msgid "Delete"
158+msgstr ""
159+
160 #. TRANSLATORS: this is the name of the playlists page shown in the tab header.
161 #. Remember to keep the translation short to fit the screen width
162 #: ../MusicPlaylists.qml:35
163 msgid "Playlists"
164 msgstr ""
165
166-#: ../MusicPlaylists.qml:61 ../MusicaddtoPlaylist.qml:105
167-#: ../common/SongsPage.qml:228 ../common/SongsPage.qml:229
168+#: ../MusicPlaylists.qml:61 ../MusicaddtoPlaylist.qml:77
169+#: ../common/SongsPage.qml:330 ../common/SongsPage.qml:331
170 #, qt-format
171 msgid "%1 song"
172 msgid_plural "%1 songs"
173@@ -93,116 +89,30 @@
174 msgstr[1] ""
175
176 #: ../MusicPlaylists.qml:66 ../MusicPlaylists.qml:70 ../MusicStart.qml:57
177-#: ../MusicStart.qml:71 ../common/SongsPage.qml:47 ../common/SongsPage.qml:125
178-#: ../common/SongsPage.qml:163 ../common/SongsPage.qml:172
179-#: ../common/SongsPage.qml:208 ../common/SongsPage.qml:247
180-#: ../common/SongsPage.qml:249 ../common/SongsPage.qml:266
181+#: ../MusicStart.qml:71 ../common/SongsPage.qml:47 ../common/SongsPage.qml:138
182+#: ../common/SongsPage.qml:226 ../common/SongsPage.qml:264
183+#: ../common/SongsPage.qml:273 ../common/SongsPage.qml:309
184+#: ../common/SongsPage.qml:345 ../common/SongsPage.qml:348
185+#: ../common/SongsPage.qml:364
186 msgid "Playlist"
187 msgstr ""
188
189-#: ../MusicSearch.qml:44 ../MusicSearch.qml:75 ../music-app.qml:88
190-#: ../music-app.qml:134 ../music-app.qml:140
191-msgid "Search"
192-msgstr ""
193-
194-#: ../MusicSettings.qml:30 ../music-app.qml:184
195-msgid "Settings"
196-msgstr ""
197-
198-#: ../MusicSettings.qml:70
199-msgid "Equaliser"
200-msgstr ""
201-
202-#: ../MusicSettings.qml:71
203-msgid "Default"
204-msgstr ""
205-
206-#: ../MusicSettings.qml:72
207-msgid "Acoustic"
208-msgstr ""
209-
210-#: ../MusicSettings.qml:73
211-msgid "Classical"
212-msgstr ""
213-
214-#: ../MusicSettings.qml:74
215-msgid "Electronic"
216-msgstr ""
217-
218-#: ../MusicSettings.qml:75
219-msgid "Flat"
220-msgstr ""
221-
222-#: ../MusicSettings.qml:76
223-msgid "Hip Hop"
224-msgstr ""
225-
226-#: ../MusicSettings.qml:77
227-msgid "Jazz"
228-msgstr ""
229-
230-#: ../MusicSettings.qml:78
231-msgid "Metal"
232-msgstr ""
233-
234-#: ../MusicSettings.qml:79
235-msgid "Pop"
236-msgstr ""
237-
238-#: ../MusicSettings.qml:80
239-msgid "Rock"
240-msgstr ""
241-
242-#: ../MusicSettings.qml:81
243-msgid "Custom"
244-msgstr ""
245-
246-#: ../MusicSettings.qml:101
247-msgid ""
248-"Snap to current song \n"
249-"when opening toolbar"
250-msgstr ""
251-
252-#: ../MusicSettings.qml:121
253-msgid "Accounts"
254-msgstr ""
255-
256-#: ../MusicSettings.qml:135
257-msgid "Login to scrobble and import playlists"
258-msgstr ""
259-
260-#: ../MusicSettings.qml:158
261-msgid "Music Streaming"
262-msgstr ""
263-
264-#: ../MusicSettings.qml:168
265-msgid "Ubuntu One"
266-msgstr ""
267-
268-#: ../MusicSettings.qml:169
269-msgid "Sign in to stream your cloud music"
270-msgstr ""
271-
272-#: ../MusicSettings.qml:185
273-msgid "Stream only on Wi-Fi"
274-msgstr ""
275-
276-#: ../MusicSettings.qml:219
277-msgid "Clean everything!"
278-msgstr ""
279-
280-#: ../MusicStart.qml:35
281+#: ../MusicStart.qml:34
282 msgid "Recent"
283 msgstr ""
284
285-#: ../MusicToolbar.qml:150
286+#: ../MusicToolbar.qml:148
287 msgid "Tap to shuffle music"
288 msgstr ""
289
290-#: ../MusicTracks.qml:35
291+#: ../MusicTracks.qml:34
292 msgid "Songs"
293 msgstr ""
294
295+#: ../MusicTracks.qml:78 ../common/SongsPage.qml:125
296+msgid "Add to queue"
297+msgstr ""
298+
299 #: ../MusicaddtoPlaylist.qml:41
300 msgid "Select playlist"
301 msgstr ""
302@@ -211,15 +121,15 @@
303 msgid "New playlist"
304 msgstr ""
305
306-#: ../common/AlbumsPage.qml:55 ../common/SongsPage.qml:115
307+#: ../common/AlbumsPage.qml:55 ../common/SongsPage.qml:216
308 msgid "Shuffle"
309 msgstr ""
310
311-#: ../common/AlbumsPage.qml:72 ../common/SongsPage.qml:142
312+#: ../common/AlbumsPage.qml:72 ../common/SongsPage.qml:243
313 msgid "Queue all"
314 msgstr ""
315
316-#: ../common/AlbumsPage.qml:83 ../common/SongsPage.qml:153
317+#: ../common/AlbumsPage.qml:83 ../common/SongsPage.qml:254
318 msgid "Play all"
319 msgstr ""
320
321@@ -230,15 +140,11 @@
322 msgstr[0] ""
323 msgstr[1] ""
324
325-#: ../common/ListItemActions/AddToPlaylist.qml:25 ../music-app.qml:905
326-msgid "Add to playlist"
327-msgstr ""
328-
329 #: ../common/ListItemActions/AddToQueue.qml:25
330 msgid "Add to Queue"
331 msgstr ""
332
333-#: ../common/ListItemActions/Remove.qml:27 ../common/SongsPage.qml:400
334+#: ../common/ListItemActions/Remove.qml:27 ../common/SongsPage.qml:495
335 msgid "Remove"
336 msgstr ""
337
338@@ -246,51 +152,41 @@
339 msgid "Loading..."
340 msgstr ""
341
342-#: ../common/SongsPage.qml:122 ../common/SongsPage.qml:160
343-#: ../common/SongsPage.qml:173 ../common/SongsPage.qml:209
344-#: ../common/SongsPage.qml:228 ../common/SongsPage.qml:263
345-msgid "Genre"
346-msgstr ""
347-
348 #. TRANSLATORS: this is a title of a dialog with a prompt to rename a playlist
349-#: ../common/SongsPage.qml:333
350+#: ../common/SongsPage.qml:428
351 msgid "Change name"
352 msgstr ""
353
354-#: ../common/SongsPage.qml:334
355+#: ../common/SongsPage.qml:429
356 msgid "Enter the new name of the playlist."
357 msgstr ""
358
359-#: ../common/SongsPage.qml:351
360+#: ../common/SongsPage.qml:446
361 msgid "Change"
362 msgstr ""
363
364-#: ../common/SongsPage.qml:372 ../music-app.qml:959
365+#: ../common/SongsPage.qml:467 ../music-app.qml:825
366 msgid "Playlist already exists"
367 msgstr ""
368
369-#: ../common/SongsPage.qml:376 ../music-app.qml:964
370+#: ../common/SongsPage.qml:471 ../music-app.qml:830
371 msgid "Please type in a name."
372 msgstr ""
373
374-#: ../common/SongsPage.qml:381 ../common/SongsPage.qml:420
375-#: ../music-app.qml:499 ../music-app.qml:970
376+#: ../common/SongsPage.qml:476 ../common/SongsPage.qml:514
377+#: ../music-app.qml:485 ../music-app.qml:836
378 msgid "Cancel"
379 msgstr ""
380
381 #. TRANSLATORS: this is a title of a dialog with a prompt to delete a playlist
382-#: ../common/SongsPage.qml:394
383+#: ../common/SongsPage.qml:489
384 msgid "Are you sure?"
385 msgstr ""
386
387-#: ../common/SongsPage.qml:395
388+#: ../common/SongsPage.qml:490
389 msgid "This will delete your playlist."
390 msgstr ""
391
392-#: ../common/SwipeDelete.qml:52 ../common/SwipeDelete.qml:88
393-msgid "Clear"
394-msgstr ""
395-
396 #: ../meta-database.js:90 ../meta-database.js:92
397 msgid "Unknown Album"
398 msgstr ""
399@@ -299,139 +195,151 @@
400 msgid "Unknown Artist"
401 msgstr ""
402
403-#: ../music-app.qml:135
404+#: ../music-app.qml:85 ../music-app.qml:131 ../music-app.qml:137
405+msgid "Search"
406+msgstr ""
407+
408+#: ../music-app.qml:132
409 msgid "Search Track"
410 msgstr ""
411
412-#: ../music-app.qml:147
413+#: ../music-app.qml:144
414 msgid "Next"
415 msgstr ""
416
417-#: ../music-app.qml:148
418+#: ../music-app.qml:145
419 msgid "Next Track"
420 msgstr ""
421
422-#: ../music-app.qml:154
423+#: ../music-app.qml:151
424 msgid "Pause"
425 msgstr ""
426
427-#: ../music-app.qml:154
428+#: ../music-app.qml:151
429 msgid "Play"
430 msgstr ""
431
432-#: ../music-app.qml:156
433+#: ../music-app.qml:153
434 msgid "Pause Playback"
435 msgstr ""
436
437-#: ../music-app.qml:156
438+#: ../music-app.qml:153
439 msgid "Continue or start playback"
440 msgstr ""
441
442-#: ../music-app.qml:161
443+#: ../music-app.qml:158
444 msgid "Back"
445 msgstr ""
446
447-#: ../music-app.qml:162
448+#: ../music-app.qml:159
449 msgid "Go back to last page"
450 msgstr ""
451
452-#: ../music-app.qml:170
453+#: ../music-app.qml:167
454 msgid "Previous"
455 msgstr ""
456
457-#: ../music-app.qml:171
458+#: ../music-app.qml:168
459 msgid "Previous Track"
460 msgstr ""
461
462-#: ../music-app.qml:176
463+#: ../music-app.qml:173
464 msgid "Stop"
465 msgstr ""
466
467-#: ../music-app.qml:177
468+#: ../music-app.qml:174
469 msgid "Stop Playback"
470 msgstr ""
471
472-#: ../music-app.qml:185
473-msgid "Music Settings"
474-msgstr ""
475-
476 #. TRANSLATORS: This string represents that the target destination filepath does not start with ~/Music/Imported/
477-#: ../music-app.qml:342
478+#: ../music-app.qml:328
479 msgid "Filepath must start with"
480 msgstr ""
481
482 #. TRANSLATORS: This string represents that a blank filepath destination has been used
483-#: ../music-app.qml:368
484+#: ../music-app.qml:354
485 msgid "Filepath must be a file"
486 msgstr ""
487
488 #. TRANSLATORS: This string represents that there was failure moving the file to the target destination
489-#: ../music-app.qml:374
490+#: ../music-app.qml:360
491 msgid "Failed to move file"
492 msgstr ""
493
494-#: ../music-app.qml:453
495+#: ../music-app.qml:439
496 msgid "Waiting for file(s)..."
497 msgstr ""
498
499-#: ../music-app.qml:472
500+#: ../music-app.qml:458
501 msgid "OK"
502 msgstr ""
503
504-#: ../music-app.qml:485
505+#: ../music-app.qml:471
506 msgid "Imported file not found"
507 msgstr ""
508
509-#: ../music-app.qml:489
510+#: ../music-app.qml:475
511 msgid "Wait"
512 msgstr ""
513
514 #. TRANSLATORS: this refers to a number of songs greater than one. The actual number will be prepended to the string automatically (plural forms are not yet fully supported in usermetrics, the library that displays that string)
515-#: ../music-app.qml:510
516+#: ../music-app.qml:496
517 msgid "songs played today"
518 msgstr ""
519
520-#: ../music-app.qml:511
521+#: ../music-app.qml:497
522 msgid "No songs played today"
523 msgstr ""
524
525-#: ../music-app.qml:591 ../music-app.qml:1155
526+#: ../music-app.qml:563 ../music-app.qml:1038
527 #: com.ubuntu.music_music.desktop.in.in.h:1
528 msgid "Music"
529 msgstr ""
530
531-#: ../music-app.qml:613
532+#: ../music-app.qml:581
533 msgid "Debug: "
534 msgstr ""
535
536-#: ../music-app.qml:891
537-msgid "Add to queue"
538-msgstr ""
539-
540-#: ../music-app.qml:928
541+#: ../music-app.qml:794
542 msgid "New Playlist"
543 msgstr ""
544
545-#: ../music-app.qml:929
546+#: ../music-app.qml:795
547 msgid "Name your playlist."
548 msgstr ""
549
550-#: ../music-app.qml:933
551+#: ../music-app.qml:799
552 msgid "Name"
553 msgstr ""
554
555-#: ../music-app.qml:943
556+#: ../music-app.qml:809
557 msgid "Create"
558 msgstr ""
559
560-#: ../music-app.qml:1181
561+#: ../music-app.qml:1068
562 msgid "No music found"
563 msgstr ""
564
565-#: ../music-app.qml:1188
566+#: ../music-app.qml:1075
567 msgid "Please import music"
568 msgstr ""
569
570+#: ../music-app.qml:1098
571+msgid "No playlists found"
572+msgstr ""
573+
574+#: ../music-app.qml:1105
575+msgid "Click the + to create a playlist"
576+msgstr ""
577+
578+#: ../music-app.qml:1128
579+msgid "No recent albums or playlists found"
580+msgstr ""
581+
582+#: ../music-app.qml:1135
583+msgid "Play some music to see your favorites"
584+msgstr ""
585+
586 #: com.ubuntu.music_music.desktop.in.in.h:2
587 msgid "A music application for Ubuntu"
588 msgstr ""

Subscribers

People subscribed via source and target branches