Merge lp:~ahayzen/music-app/remix-perf-002 into lp:music-app/remix

[Andrew Hayzen]

* Use async for loaders and unused loaders invisible

* Use async for loaders and unused loaders invisible

[lp:~ahayzen/music-app/remix-perf-002]

692. By Andrew Hayzen on 2014-10-22

* Add additional async

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:691
http://91.189.93.70:8080/job/music-app-remix-ci/147/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1175
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1175/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-remix-utopic-amd64-ci/147

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-remix-ci/147/rebuild

review: Approve (continuous-integration)

[Victor Thompson (vthompson)]

LGTM, we will want to profile the improvements this makes as well.

review: Approve

=== modified file 'common/BlurredHeader.qml'
--- common/BlurredHeader.qml	2014-10-20 15:39:09 +0000
+++ common/BlurredHeader.qml	2014-10-22 17:39:14 +0000
@@ -54,6 +54,7 @@
             left: coversImage.right
             leftMargin: units.gu(2)
         }
+        asynchronous: true
     }
 
     Loader {
@@ -65,5 +66,6 @@
             top: coversImage.bottom
             topMargin: units.gu(1)
         }
+        asynchronous: true
     }
 }

=== modified file 'common/CardView.qml'
--- common/CardView.qml	2014-10-14 15:46:07 +0000
+++ common/CardView.qml	2014-10-22 17:39:14 +0000
@@ -37,6 +37,8 @@
 
     Loader {
         id: headerLoader
+        asynchronous: true
+        visible: sourceComponent !== undefined
         width: parent.width
     }
 

=== modified file 'common/ListItemWithActions.qml'
--- common/ListItemWithActions.qml	2014-10-21 21:12:55 +0000
+++ common/ListItemWithActions.qml	2014-10-22 17:39:14 +0000
@@ -449,8 +449,10 @@
                 left: main.left
                 verticalCenter: main.verticalCenter
             }
+            asynchronous: true  // CUSTOM
             width: (status === Loader.Ready) ? item.implicitWidth : 0
             visible: (status === Loader.Ready) && (item.width === item.implicitWidth)
+
             Behavior on width {
                 NumberAnimation {
                     duration: UbuntuAnimation.SnapDuration

=== modified file 'common/MusicRow.qml'
--- common/MusicRow.qml	2014-10-20 20:51:31 +0000
+++ common/MusicRow.qml	2014-10-22 17:39:14 +0000
@@ -55,6 +55,7 @@
             top: parent.top
             topMargin: units.gu(1)
         }
+        asynchronous: true
         width: !showCovers ? parent.width - parent.spacing
                            : parent.width - coverGrid.width - parent.spacing