Merge lp:~ahayzen/music-app/remix-fix-playlists-slow into lp:music-app/remix

[Andrew Hayzen]

* Change playlistModel syncFactor to 1
* Never attempt to ping when processing a sync pong

* Change playlistModel syncFactor to 1
* Never attempt to ping when processing a sync pong

[lp:~ahayzen/music-app/remix-fix-playlists-slow]

710. By Andrew Hayzen on 2014-10-28

* Don't check list length if null

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:709
http://91.189.93.70:8080/job/music-app-remix-ci/202/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1329
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1329/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-remix-utopic-amd64-ci/202

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-remix-ci/202/rebuild

review: Approve (continuous-integration)

[Victor Thompson (vthompson)]

LGTM, this fixes the regression that was causing playlist items to load slowly in the SongsPage.

review: Approve

=== modified file 'WorkerModelLoader.qml'
--- WorkerModelLoader.qml	2014-10-27 23:45:25 +0000
+++ WorkerModelLoader.qml	2014-10-28 03:21:31 +0000
@@ -50,11 +50,11 @@
 
      onMessage: {
          if (messageObject.sync === true) {
-             if (i >= list.length) {  // if synced check if list now complete
+             if (list !== null && i >= list.length) {  // if synced check if list now complete
                  completed = true
-             } else {
-                 return;  // do not continue from a sync 'pong' only from a process/clear
              }
+
+             return;  // do not continue from a sync 'pong' only from a process/clear
          }
 
          if (i === 0) {

=== modified file 'music-app.qml'
--- music-app.qml	2014-10-28 00:15:37 +0000
+++ music-app.qml	2014-10-28 03:21:31 +0000
@@ -809,6 +809,7 @@
     // create the listmodel to use for playlists
     LibraryListModel {
         id: playlistModel
+        syncFactor: 1
 
         onPreLoadCompleteChanged: {
             if (preLoadComplete)