Ubuntu Music App

Merge lp:~ahayzen/music-app/remix-fix-1386712-rename-playlist-crash into lp:music-app/remix

  1. remix-fix-1386712-rename-playlist-crash
  2. Merge into remix
Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 714
Merged at revision: 714
Proposed branch: lp:~ahayzen/music-app/remix-fix-1386712-rename-playlist-crash
Merge into: lp:music-app/remix
Diff against target: 14 lines (+3/-1)
1 file modified
common/SongsPage.qml (+3/-1)
To merge this branch: bzr merge lp:~ahayzen/music-app/remix-fix-1386712-rename-playlist-crash
Reviewer Review Type Date Requested Status
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+239890@code.launchpad.net

Commit message

* Fix for edit playlist causing crashes

Description of the change

* Fix for edit playlist causing crashes

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:714
http://91.189.93.70:8080/job/music-app-remix-ci/207/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1352
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1352/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-remix-utopic-amd64-ci/207

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-remix-ci/207/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

LGTM! Thanks for the quick fix!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'common/SongsPage.qml'
2--- common/SongsPage.qml 2014-10-28 03:32:01 +0000
3+++ common/SongsPage.qml 2014-10-28 18:02:55 +0000
4@@ -470,7 +470,9 @@
5 console.debug("Debug: User changed name from "+playlistName.placeholderText+" to "+playlistName.text)
6
7 if (Playlists.renamePlaylist(playlistName.placeholderText, playlistName.text) === true) {
8- playlistModel.filterPlaylists()
9+ if (songStackPage.page !== undefined) {
10+ songStackPage.page.changed = true
11+ }
12
13 if (Library.recentContainsPlaylist(playlistName.placeholderText)) {
14 Library.recentRenamePlaylist(playlistName.placeholderText, playlistName.text)

Subscribers

People subscribed via source and target branches