Merge lp:~ahayzen/music-app/remix-bottom-margin-fix-1380102 into lp:music-app/remix

Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 695
Merged at revision: 696
Proposed branch: lp:~ahayzen/music-app/remix-bottom-margin-fix-1380102
Merge into: lp:music-app/remix
Diff against target: 23 lines (+2/-0)
2 files modified
MusicNowPlaying.qml (+1/-0)
MusicTracks.qml (+1/-0)
To merge this branch: bzr merge lp:~ahayzen/music-app/remix-bottom-margin-fix-1380102
Reviewer Review Type Date Requested Status
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+239298@code.launchpad.net

Commit message

* Add a bottom margin to MusicTracks.qml and MusicNowPlaying.qml

Description of the change

* Add a bottom margin to MusicTracks.qml and MusicNowPlaying.qml

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

LGTM! :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicNowPlaying.qml'
2--- MusicNowPlaying.qml 2014-10-22 18:17:49 +0000
3+++ MusicNowPlaying.qml 2014-10-22 20:17:39 +0000
4@@ -482,6 +482,7 @@
5 ListView {
6 id: queuelist
7 anchors {
8+ bottomMargin: units.gu(2)
9 fill: parent
10 topMargin: units.gu(2)
11 }
12
13=== modified file 'MusicTracks.qml'
14--- MusicTracks.qml 2014-10-22 17:46:50 +0000
15+++ MusicTracks.qml 2014-10-22 20:17:39 +0000
16@@ -96,6 +96,7 @@
17 ListView {
18 id: tracklist
19 anchors {
20+ bottomMargin: units.gu(2)
21 fill: parent
22 topMargin: units.gu(2)
23 }

Subscribers

People subscribed via source and target branches