Ubuntu Music App

Code review comment for lp:~ahayzen/music-app/qml-unit-test-filenames

  1. qml-unit-test-filenames
  2. Merge into trunk
Revision history for this message
Victor Thompson (vthompson) wrote :

Things to fix:

1. Please update to UC 1.3.
2. I also experienced your FIXME when running on the device. I think it's because the password isn't echoed back through adb--my password shows up in the terminal. There should be a way to echo it back.

Things to consider:

1. Oh dear that tone for the test files is kind of annoying. :)
2. Will it still make sense to have this run locally to test mh3 bg playlists? I think we might need to update the installation requirements before running the tests to install media hub. The unit tests fail locally on Xenial for me.
3. Is there a way to have the Ubuntu Application Test close after the unit tests run?

review: Needs Fixing
Reply

« Back to merge proposal