Merge lp:~ahayzen/music-app/media-hub-bg-playlists-rework-qt-56 into lp:~music-app-dev/music-app/media-hub-bg-playlists-rework

Proposed by Andrew Hayzen
Status: Merged
Merged at revision: 927
Proposed branch: lp:~ahayzen/music-app/media-hub-bg-playlists-rework-qt-56
Merge into: lp:~music-app-dev/music-app/media-hub-bg-playlists-rework
Diff against target: 86 lines (+3/-7)
7 files modified
app/components/NewPlayer.qml (+1/-1)
app/components/NowPlayingToolbar.qml (+1/-1)
app/music-app.qml (+1/-1)
app/ui/AddToPlaylist.qml (+0/-1)
app/ui/Playlists.qml (+0/-1)
app/ui/Recent.qml (+0/-1)
app/ui/Songs.qml (+0/-1)
To merge this branch: bzr merge lp:~ahayzen/music-app/media-hub-bg-playlists-rework-qt-56
Reviewer Review Type Date Requested Status
Andrew Hayzen Needs Information
Jim Hodapp (community) code Approve
Review via email: mp+281145@code.launchpad.net

Commit message

* Bump QtMultimedia import to 5.6 and remove unused ones

Description of the change

* Bump QtMultimedia import to 5.6 and remove unused ones

Separate branch, as this isn't yet in the repositories :-)

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good and functions well. Will top approve once Timo lands the changes exporting the Playlist and PlaylistItem stuff into the archive from silo 58.

https://requests.ci-train.ubuntu.com/#/ticket/812

review: Approve (code)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

As Victor suggested, we also need to update our debian/control so that we depend on the correct version of QtMultimedia. Furthermore do we need to add media-hub/qtubuntu-media to the control or does the new QtMultimedia include the Playlists objects/properties and they are only platform-side ?

review: Needs Information
Revision history for this message
Jim Hodapp (jhodapp) wrote :

You do not need to add media-hub/qtubuntu-media to the control file as this is already handled by the system and is properly abstracted from you.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/components/NewPlayer.qml'
2--- app/components/NewPlayer.qml 2015-12-17 02:14:38 +0000
3+++ app/components/NewPlayer.qml 2015-12-21 20:10:14 +0000
4@@ -16,7 +16,7 @@
5 * along with this program. If not, see <http://www.gnu.org/licenses/>.
6 */
7
8-import QtMultimedia 5.4
9+import QtMultimedia 5.6
10 import QtQuick 2.4
11 import Qt.labs.settings 1.0
12
13
14=== modified file 'app/components/NowPlayingToolbar.qml'
15--- app/components/NowPlayingToolbar.qml 2015-11-23 02:08:11 +0000
16+++ app/components/NowPlayingToolbar.qml 2015-12-21 20:10:14 +0000
17@@ -17,7 +17,7 @@
18 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 */
20
21-import QtMultimedia 5.0
22+import QtMultimedia 5.6
23 import QtQuick 2.4
24 import Ubuntu.Components 1.3
25
26
27=== modified file 'app/music-app.qml'
28--- app/music-app.qml 2015-12-17 02:14:38 +0000
29+++ app/music-app.qml 2015-12-21 20:10:14 +0000
30@@ -22,7 +22,7 @@
31 import Ubuntu.Components.Popups 1.3
32 import Ubuntu.MediaScanner 0.1
33 import Qt.labs.settings 1.0
34-import QtMultimedia 5.0
35+import QtMultimedia 5.6
36 import QtQuick.LocalStorage 2.0
37 import QtGraphicalEffects 1.0
38 import "logic/stored-request.js" as StoredRequest
39
40=== modified file 'app/ui/AddToPlaylist.qml'
41--- app/ui/AddToPlaylist.qml 2015-10-28 01:05:33 +0000
42+++ app/ui/AddToPlaylist.qml 2015-12-21 20:10:14 +0000
43@@ -17,7 +17,6 @@
44 * along with this program. If not, see <http://www.gnu.org/licenses/>.
45 */
46
47-import QtMultimedia 5.0
48 import QtQuick 2.4
49 import Ubuntu.Components 1.3
50 import QtQuick.LocalStorage 2.0
51
52=== modified file 'app/ui/Playlists.qml'
53--- app/ui/Playlists.qml 2015-10-28 01:05:33 +0000
54+++ app/ui/Playlists.qml 2015-12-21 20:10:14 +0000
55@@ -20,7 +20,6 @@
56
57 import QtQuick 2.4
58 import Ubuntu.Components 1.3
59-import QtMultimedia 5.0
60 import QtQuick.LocalStorage 2.0
61 import "../logic/playlists.js" as Playlists
62 import "../components"
63
64=== modified file 'app/ui/Recent.qml'
65--- app/ui/Recent.qml 2015-10-28 01:05:33 +0000
66+++ app/ui/Recent.qml 2015-12-21 20:10:14 +0000
67@@ -21,7 +21,6 @@
68 import Ubuntu.Components 1.3
69 import Ubuntu.MediaScanner 0.1
70 import Ubuntu.Thumbnailer 0.1
71-import QtMultimedia 5.0
72 import QtQuick.LocalStorage 2.0
73 import "../logic/meta-database.js" as Library
74 import "../logic/playlists.js" as Playlists
75
76=== modified file 'app/ui/Songs.qml'
77--- app/ui/Songs.qml 2015-12-17 02:14:38 +0000
78+++ app/ui/Songs.qml 2015-12-21 20:10:14 +0000
79@@ -21,7 +21,6 @@
80 import Ubuntu.Components 1.3
81 import Ubuntu.MediaScanner 0.1
82 import Ubuntu.Thumbnailer 0.1
83-import QtMultimedia 5.0
84 import QtQuick.LocalStorage 2.0
85 import "../logic/playlists.js" as Playlists
86 import "../components"

Subscribers

People subscribed via source and target branches