Merge lp:~ahayzen/music-app/hide-back-button-on-toolbar-hide into lp:music-app/trusty

Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 176
Merged at revision: 177
Proposed branch: lp:~ahayzen/music-app/hide-back-button-on-toolbar-hide
Merge into: lp:music-app/trusty
Diff against target: 41 lines (+27/-1)
1 file modified
MusicNowPlaying.qml (+27/-1)
To merge this branch: bzr merge lp:~ahayzen/music-app/hide-back-button-on-toolbar-hide
Reviewer Review Type Date Requested Status
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+190810@code.launchpad.net

Commit message

* Hide the back button in the now playing page when the toolbar is hidden

Description of the change

* Hide the back button in the now playing page when the toolbar is hidden

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicNowPlaying.qml'
2--- MusicNowPlaying.qml 2013-10-11 12:59:30 +0000
3+++ MusicNowPlaying.qml 2013-10-12 18:44:44 +0000
4@@ -557,10 +557,36 @@
5 id: nowPlayingBackButton
6 anchors.left: parent.left
7 anchors.right: parent.right
8- anchors.top: parent.top
9 color: styleMusic.nowPlaying.foregroundColor
10 height: units.gu(3)
11
12+ state: musicToolbar.opened ? "shown" : "hidden"
13+ states: [
14+ State {
15+ name: "shown"
16+ PropertyChanges {
17+ target: nowPlayingBackButton
18+ y: 0
19+ }
20+ },
21+ State {
22+ name: "hidden"
23+ PropertyChanges {
24+ target: nowPlayingBackButton
25+ y: -height
26+ }
27+ }
28+ ]
29+
30+ transitions: Transition {
31+ from: "hidden,shown"
32+ to: "shown,hidden"
33+ NumberAnimation {
34+ duration: 100
35+ properties: "y"
36+ }
37+ }
38+
39 Image {
40 id: expandItem
41 anchors.horizontalCenter: parent.horizontalCenter

Subscribers

People subscribed via source and target branches

to status/vote changes: