Merge lp:~ahayzen/music-app/fix-multiselect-lose-focus into lp:music-app/remix

Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 812
Merged at revision: 813
Proposed branch: lp:~ahayzen/music-app/fix-multiselect-lose-focus
Merge into: lp:music-app/remix
Diff against target: 37 lines (+3/-3)
3 files modified
MusicNowPlaying.qml (+1/-1)
MusicTracks.qml (+1/-1)
common/SongsPage.qml (+1/-1)
To merge this branch: bzr merge lp:~ahayzen/music-app/fix-multiselect-lose-focus
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Victor Thompson Approve
Review via email: mp+247547@code.launchpad.net

Commit message

* Fix for multiselect not clearing when losing focus

Description of the change

* Fix for multiselect not clearing when losing focus

To post a comment you must log in.
Revision history for this message
Victor Thompson (vthompson) wrote :

LGTM! Nice simple fix!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicNowPlaying.qml'
2--- MusicNowPlaying.qml 2015-01-25 20:04:46 +0000
3+++ MusicNowPlaying.qml 2015-01-26 03:27:21 +0000
4@@ -469,7 +469,7 @@
5 }
6 onVisibleChanged: {
7 if (!visible) {
8- clearSelection(true)
9+ closeSelection()
10 }
11 }
12
13
14=== modified file 'MusicTracks.qml'
15--- MusicTracks.qml 2015-01-25 16:44:49 +0000
16+++ MusicTracks.qml 2015-01-26 03:27:21 +0000
17@@ -181,7 +181,7 @@
18 }
19 onVisibleChanged: {
20 if (!visible) {
21- clearSelection(true)
22+ closeSelection()
23 }
24 }
25
26
27=== modified file 'common/SongsPage.qml'
28--- common/SongsPage.qml 2015-01-25 16:44:49 +0000
29+++ common/SongsPage.qml 2015-01-26 03:27:21 +0000
30@@ -283,7 +283,7 @@
31 }
32 onVisibleChanged: {
33 if (!visible) {
34- clearSelection(true)
35+ closeSelection()
36 }
37 }
38

Subscribers

People subscribed via source and target branches