Merge lp:~ahayzen/music-app/fix-console-errors-parent-changed-helpers into lp:music-app
Proposed by
Andrew Hayzen
Status: | Merged |
---|---|
Approved by: | Victor Thompson |
Approved revision: | 891 |
Merged at revision: | 891 |
Proposed branch: | lp:~ahayzen/music-app/fix-console-errors-parent-changed-helpers |
Merge into: | lp:music-app |
Diff against target: |
61 lines (+9/-10) 2 files modified
app/ui/SongsView.qml (+6/-10) debian/changelog (+3/-0) |
To merge this branch: | bzr merge lp:~ahayzen/music-app/fix-console-errors-parent-changed-helpers |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Victor Thompson | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+265920@code.launchpad.net |
Commit message
* Fix for console errors when the parent change helpers are called
Description of the change
* Fix for console errors when the parent change helpers are called
TESTING:
At step 5 below there is now no console error and I've fixed other potential places this could occur
1) Start the app
2) Goto albums
3) Select an album
4) Select play all
5) Notice in the console an error like the following
file://
To post a comment you must log in.
PASSED: Continuous integration, rev:891 91.189. 93.70:8080/ job/music- app-ci/ 1351/ 91.189. 93.70:8080/ job/music- app-vivid- amd64-ci/ 203
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/music- app-ci/ 1351/rebuild
http://