Merge lp:~ahayzen/music-app/fix-1409754-albums-uri-use-albumArtist into lp:music-app/remix

Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 781
Merged at revision: 781
Proposed branch: lp:~ahayzen/music-app/fix-1409754-albums-uri-use-albumArtist
Merge into: lp:music-app/remix
Diff against target: 21 lines (+2/-2)
1 file modified
music-app.qml (+2/-2)
To merge this branch: bzr merge lp:~ahayzen/music-app/fix-1409754-albums-uri-use-albumArtist
Reviewer Review Type Date Requested Status
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+246220@code.launchpad.net

Commit message

* Switch to albumArtist when using album://

Description of the change

* Switch to albumArtist when using album://

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Tested with problematic "various" tracks and full albums.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

LGTM! As expected, this fix allows the Album Artist to be found by the app. Thanks for the quick turn!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'music-app.qml'
2--- music-app.qml 2015-01-11 17:30:09 +0000
3+++ music-app.qml 2015-01-12 20:34:30 +0000
4@@ -193,7 +193,7 @@
5 }
6
7 // Filter by artist and album
8- songsAlbumArtistModel.artist = decodeURIComponent(split[0]);
9+ songsAlbumArtistModel.albumArtist = decodeURIComponent(split[0]);
10 songsAlbumArtistModel.album = decodeURIComponent(split[1]);
11 }
12
13@@ -752,7 +752,7 @@
14 selectedAlbum = false;
15
16 // Clear filter for artist and album
17- songsAlbumArtistModel.artist = ""
18+ songsAlbumArtistModel.albumArtist = ""
19 songsAlbumArtistModel.album = ""
20 }
21 }

Subscribers

People subscribed via source and target branches