Merge lp:~ahayzen/music-app/fix-1315775 into lp:music-app/trusty

Proposed by Andrew Hayzen
Status: Rejected
Rejected by: Victor Thompson
Proposed branch: lp:~ahayzen/music-app/fix-1315775
Merge into: lp:music-app/trusty
Diff against target: 53 lines (+21/-0)
3 files modified
MusicaddtoPlaylist.qml (+7/-0)
common/AlbumsSheet.qml (+7/-0)
common/SongsSheet.qml (+7/-0)
To merge this branch: bzr merge lp:~ahayzen/music-app/fix-1315775
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Victor Thompson Needs Information
Review via email: mp+218204@code.launchpad.net

Commit message

* Block mouse wheel events on sheets to children

Description of the change

* Block mouse wheel events on sheets to children

To post a comment you must log in.
Revision history for this message
Victor Thompson (vthompson) wrote :

Need information per comment #1 in the bug

https://bugs.launchpad.net/music-app/+bug/1315775/comments/1

review: Needs Information
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Unmerged revisions

446. By Andrew Hayzen

* Block mouse wheel events on sheets to children

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicaddtoPlaylist.qml'
2--- MusicaddtoPlaylist.qml 2014-04-13 20:08:45 +0000
3+++ MusicaddtoPlaylist.qml 2014-05-04 01:30:35 +0000
4@@ -58,6 +58,13 @@
5 }
6 }
7
8+ MouseArea {
9+ anchors {
10+ fill: parent
11+ }
12+ onWheel: wheel.accepted = true
13+ }
14+
15 Rectangle {
16 width: parent.width
17 height: parent.height
18
19=== modified file 'common/AlbumsSheet.qml'
20--- common/AlbumsSheet.qml 2014-05-02 22:30:57 +0000
21+++ common/AlbumsSheet.qml 2014-05-04 01:30:35 +0000
22@@ -51,6 +51,13 @@
23 }
24 }
25
26+ MouseArea {
27+ anchors {
28+ fill: parent
29+ }
30+ onWheel: wheel.accepted = true
31+ }
32+
33 ListView {
34 clip: true
35 id: albumtrackslist
36
37=== modified file 'common/SongsSheet.qml'
38--- common/SongsSheet.qml 2014-04-13 20:08:45 +0000
39+++ common/SongsSheet.qml 2014-05-04 01:30:35 +0000
40@@ -54,6 +54,13 @@
41 }
42 }
43
44+ MouseArea {
45+ anchors {
46+ fill: parent
47+ }
48+ onWheel: wheel.accepted = true
49+ }
50+
51 ListView {
52 clip: true
53 id: albumtrackslist

Subscribers

People subscribed via source and target branches

to status/vote changes: