Merge lp:~ahayzen/music-app/autopilot-move-py3 into lp:music-app/trusty

Proposed by Andrew Hayzen
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 615
Merged at revision: 618
Proposed branch: lp:~ahayzen/music-app/autopilot-move-py3
Merge into: lp:music-app/trusty
Diff against target: 31 lines (+2/-3)
2 files modified
debian/control (+1/-2)
tests/autopilot/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~ahayzen/music-app/autopilot-move-py3
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nicholas Skaggs (community) Approve
Victor Thompson Needs Information
Review via email: mp+233431@code.launchpad.net

Commit message

* Use python3 for autopilot in all cases

Description of the change

* Use python3 for autopilot in all cases

This allows jenkins to use python 3 as well as devices.

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

#blocked bug 1365247 (mediascanner2 db schema change)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

#unblocked

Revision history for this message
Victor Thompson (vthompson) wrote :

See inline comment/question: Do we still directly depend on python-mock?

review: Needs Information
Revision history for this message
Nicholas Skaggs (nskaggs) :
615. By Andrew Hayzen

* Remove python-mock depends

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Kicked off a trial run of this under python3 here:

http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/250/

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

LGTM, passes py3 jenkins.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-07-01 23:13:50 +0000
3+++ debian/control 2014-09-08 13:27:30 +0000
4@@ -5,7 +5,7 @@
5 Build-Depends: cmake,
6 debhelper (>= 9),
7 intltool,
8- python,
9+ python3,
10 qt5-default,
11 Standards-Version: 3.9.4
12 Homepage: https://launchpad.net/music-app
13@@ -39,7 +39,6 @@
14 Depends: libautopilot-qt (>= 1.4),
15 libqt5test5,
16 music-app (= ${source:Version}),
17- python-mock,
18 ubuntu-ui-toolkit-autopilot,
19 ${misc:Depends},
20 Description: Autopilot tests for Music App
21
22=== modified file 'tests/autopilot/CMakeLists.txt'
23--- tests/autopilot/CMakeLists.txt 2014-05-26 16:50:13 +0000
24+++ tests/autopilot/CMakeLists.txt 2014-09-08 13:27:30 +0000
25@@ -1,5 +1,5 @@
26 if(INSTALL_TESTS)
27-execute_process(COMMAND python -c "from distutils.sysconfig import get_python_lib; print get_python_lib()"
28+execute_process(COMMAND python3 -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
29 OUTPUT_VARIABLE PYTHON_PACKAGE_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
30
31 install(DIRECTORY ${AUTOPILOT_DIR}

Subscribers

People subscribed via source and target branches

to status/vote changes: