Merge lp:~ahayzen/music-app/ap-wait-for-bounce-animation into lp:music-app/trusty

Proposed by Andrew Hayzen
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 638
Merged at revision: 638
Proposed branch: lp:~ahayzen/music-app/ap-wait-for-bounce-animation
Merge into: lp:music-app/trusty
Diff against target: 21 lines (+4/-0)
1 file modified
tests/autopilot/music_app/__init__.py (+4/-0)
To merge this branch: bzr merge lp:~ahayzen/music-app/ap-wait-for-bounce-animation
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nicholas Skaggs (community) Approve
Review via email: mp+236019@code.launchpad.net

Commit message

* Add waits for the bounce animation on a listitem action

Description of the change

* Add waits for the bounce animation on a listitem action

Due to some recent jenkins failures [0] [1] it has been noted that the listitem actions helper doesn't wait until the swipe animation is complete. Therefore this mp adds a wait :)

0 - http://91.189.93.70:8080/job/music-app-autolanding/612/console
1 - http://91.189.93.70:8080/job/music-app-ci/1133/console

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Yummy, good work spotting it (no inconsistent test runs allowed!) and pushing a fix.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/music_app/__init__.py'
2--- tests/autopilot/music_app/__init__.py 2014-09-05 22:20:29 +0000
3+++ tests/autopilot/music_app/__init__.py 2014-09-25 18:11:22 +0000
4@@ -367,6 +367,8 @@
5
6 self.pointing_device.drag(start_x, start_y, stop_x, stop_y)
7
8+ self.swipping.wait_for(False)
9+
10 def swipe_to_delete(self):
11 x, y, width, height = self.globalRect
12 start_x = x + (width * 0.2)
13@@ -375,6 +377,8 @@
14
15 self.pointing_device.drag(start_x, start_y, stop_x, stop_y)
16
17+ self.swipping.wait_for(False)
18+
19
20 class Dialog(UbuntuUIToolkitCustomProxyObjectBase):
21 @click_object

Subscribers

People subscribed via source and target branches

to status/vote changes: