Merge lp:~ahayzen/music-app/add-manual-tests-001 into lp:music-app

Proposed by Andrew Hayzen
Status: Superseded
Proposed branch: lp:~ahayzen/music-app/add-manual-tests-001
Merge into: lp:music-app
Diff against target: 344 lines (+306/-0)
6 files modified
debian/changelog (+3/-0)
tests/manual/music_app/jobs/external.pxu (+55/-0)
tests/manual/music_app/jobs/library.pxu (+124/-0)
tests/manual/music_app/jobs/playlists.pxu (+66/-0)
tests/manual/music_app/jobs/queue.pxu (+37/-0)
tests/manual/music_app/jobs/recent.pxu (+21/-0)
To merge this branch: bzr merge lp:~ahayzen/music-app/add-manual-tests-001
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Needs Fixing
Nicholas Skaggs (community) Needs Fixing
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+272050@code.launchpad.net

This proposal has been superseded by a proposal from 2015-12-16.

Commit message

* Add manual tests in checkbox format to repo

Description of the change

* Add manual tests in checkbox format to repo

This has been directly copied from the old manual tests [0]

Note that the durations are all 600 and that any notes/prerequisites I've currently put in the 1.

0 - http://pad.ubuntu.com/MusicAppManualTesting

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:918
http://91.189.93.70:8080/job/music-app-ci/1381/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/233

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1381/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

I noticed a few small things, but otherwise this lgtm.

review: Needs Fixing
919. By Andrew Hayzen

* Modify tests that use SD card to not mention krillin and include the 'only applicable'
* Add capitalisation

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

* Modify tests that use SD card to not mention krillin and include the 'only applicable'
* Add capitalisation

Please retest :-)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:919
http://91.189.93.70:8080/job/music-app-ci/1383/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/235

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1383/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

This looks good to me. I'd like to get balloon's final opinion prior to merging, however.

review: Approve
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

These are fine, but will need a provider and folder layout to make them plug and play. I'll bundle them and try them before providing a diff.

It's not crystal clear if we do want to include the provider in here, so perhaps these will be a-ok.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Prefix the tests file names with 'music-'

You are missing a colon
s/_description/_description:/g

Still deciding on the provider / no provider bit.

review: Needs Fixing
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Ohh my, I didn't notice the embedded links for results! Those won't play nice on the phone. Not sure what to do with them right now, other than to ensure there is text to go along with them.

It is possible to embed the image, but we are limited to text because of how QA stores the tests and processes them. It may be possible to embed them anyway though :p

review: Needs Fixing
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Leaving a note on how the images would have to be embedded. We would have to change the job type, as well as package the images and reference them.

use qml type of job
include $your_file.png in the 'data' dir of the provider
reference it as Qt.resolvedUrl("$your_file.png")

Revision history for this message
Victor Thompson (vthompson) wrote :

I'm going to hold off on reviewing this for now. Andrew, could you look into balloon's concerns?

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

919. By Andrew Hayzen

* Modify tests that use SD card to not mention krillin and include the 'only applicable'
* Add capitalisation

918. By Andrew Hayzen

* Merge of trunk
* Add changelog text

917. By Andrew Hayzen

* Add manual tests in checkbox format to repo

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-09-08 14:18:46 +0000
3+++ debian/changelog 2015-09-25 10:19:56 +0000
4@@ -3,6 +3,9 @@
5 [ Bartosz Kosiorek ]
6 * Reduce size of images (with tinypng.com) to decrease click size and improve performance
7
8+ [ Andrew Hayzen ]
9+ * Add manual tests in checkbox format to repo
10+
11 -- Bartosz Kosiorek <gang65@poczta.onet.pl> Tue, 08 Sep 2015 10:08:49 +0200
12
13 music-app (2.2ubuntu1) vivid; urgency=medium
14
15=== added directory 'tests/manual'
16=== added directory 'tests/manual/music_app'
17=== added directory 'tests/manual/music_app/jobs'
18=== added file 'tests/manual/music_app/jobs/external.pxu'
19--- tests/manual/music_app/jobs/external.pxu 1970-01-01 00:00:00 +0000
20+++ tests/manual/music_app/jobs/external.pxu 2015-09-25 10:19:56 +0000
21@@ -0,0 +1,55 @@
22+id: external/uri-handler
23+plugin: manual
24+_summary: Test music appears in scope and can be launched
25+estimated_duration: 600
26+_description
27+ Test music appears in scope and can be launched
28+ 1. Switch to music scope
29+ Expect to see artists:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-101609.png
30+ Sometimes the search in the scope doesn't seem to load. I'll recreate and file that later since it's the scope and not the app
31+ 2. Tap artist
32+ Expect to see zoomed in view of artist and below it, some albums:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-101722.png
33+ 3. Tap album
34+ Expect to see a zoomed in view of the album including a list of tracks and button to play in music app:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-101752.png
35+ 4. Tap "Play in music app"
36+ Expect to see music app launch and a track to start playing:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-101818.png
37+
38+id: external/content-hub
39+plugin: manual
40+_summary: Test music can be imported via content-hub
41+estimated_duration: 600
42+_description
43+ Test music can be imported via content-hub
44+ 1. Open the browser, navigate to jamendo.com
45+ 2. Find a song to download
46+ 3. Select to "Open with" the Music app
47+ 4. When the download is finished, select "Open"
48+ Expect the music app to open
49+ Expect the track to be imported into ~/Music/Imported
50+ Expect the current queue to be cleared and replaced by the item(s) imported via content-hub
51+ Expect the first song in the import to start playing
52+
53+id: external/headphones
54+plugin: manual
55+_summary: Test music plays in headphones
56+estimated_duration: 600
57+_description
58+ Test music plays in headphones
59+ 1. Play music in app
60+ 2. Attach headphones
61+ Expect music to play through headphones
62+ 3. Detach headphones
63+ Expect the music to pause
64+ 4. Select play
65+ Expect music to play through internal speaker
66+
67+id: external/infographics
68+plugin: manual
69+_summary: Test welcome screen stats
70+estimated_duration: 600
71+_description
72+ Test welcome screen stats
73+ 1. Note: This should be done after the above tests have been completed, and music has been played successfully
74+ 2. Tap power button to lock screen
75+ 3. Tap power button to wake phone
76+ Expect to see user metrics of songs played (may need to tap-tap this screen to loop round to "songs played today"):- http://people.canonical.com/~alan/screenshots/device-2014-11-17-210613.png
77
78=== added file 'tests/manual/music_app/jobs/library.pxu'
79--- tests/manual/music_app/jobs/library.pxu 1970-01-01 00:00:00 +0000
80+++ tests/manual/music_app/jobs/library.pxu 2015-09-25 10:19:56 +0000
81@@ -0,0 +1,124 @@
82+id: library/empty-state
83+plugin: manual
84+_summary: Test to check that the empty state for the library is shown
85+estimated_duration: 600
86+_description
87+ Test to check that the empty state for the library is shown
88+ 1. Launch music app with no music on device (and no or empty SD card if applicable)
89+ 2. Expected empty state screen
90+ http://people.canonical.com/~alan/screenshots/device-2015-01-23-094554.png
91+
92+id: library/music-appears
93+plugin: manual
94+_summary: Test music appearing when on device
95+estimated_duration: 600
96+_description
97+ Test music appearing when on device
98+ 1. Launch music app
99+ 2. Unlock device
100+ 3. On desktop navigate to Devices -> Device name -> Music
101+ 4. Copy music over USB cable via MTP to Music folder
102+ Note: Only MP3 and FLAC files.
103+ 5. Expect to see music appearing inside the application with appropriate artwork (this may take a while as mediascanner looks for music)
104+
105+id: library/music-appears-views
106+plugin: manual
107+_summary: Test music appears appropriately in each view
108+estimated_duration: 600
109+_description
110+ Test music appears appropriately in each view
111+ 1. Launch music app - expect populated views
112+ 2. Switch to Artists view
113+ Expect to see artists listed in card view:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-101312.png
114+ 3. Switch to Albums view
115+ Expect to see album covers:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-101331.png
116+ 4. Switch to Genres view
117+ Expect to see (multiple if copied) genres with (multiple if appropriate) album cover art:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-101348.png
118+ 5. Switch to Songs view
119+ Expect to see a list of all songs on the device including album art:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-101402.png
120+ 6. Expect recent to not exist in the tabs
121+ 7. Switch to Playlists view
122+ Expect empty view Playlists:- http://people.canonical.com/~alan/screenshots/device-2015-01-23-094234.png
123+
124+id: library/music-appears-sd-card
125+plugin: manual
126+_summary: Test music appearing when on sdcard
127+estimated_duration: 600
128+_description
129+ Test music appearing when on sdcard
130+ 1. (only applicable on devices with sdcard support)
131+ 2. Unlock device
132+ then wait a few moments for the SD card to show up
133+ 3. On desktop navigate to Devices -> Device name -> SDCARD -> Music
134+ 4. Copy music over USB cable via MTP to Music folder
135+ 5. Launch Music app
136+ 6. Expect music to show up in Songs, Artists and Albums view in Music app
137+
138+id: library/deletion-of-music
139+plugin: manual
140+_summary: Test deletion of music
141+estimated_duration: 600
142+_description
143+ Test deletion of music
144+ 1. Open music app, observe music in Albums view
145+ 2. Ensure phone is unlocked
146+ 3. Connect phone via USB
147+ 4. On desktop navigate to Devices -> Device name -> Music and delete an entire album folder
148+ Cannot delete via mtp, will file separately (right click delete in nautilus)
149+ 5. Expect the album disappears from the music player shortly afterwards
150+
151+id: library/search-albums
152+plugin: manual
153+_summary: Test Search Albums
154+estimated_duration: 600
155+_description
156+ Test Search Albums
157+ 1. Navigate to Albums view
158+ 2. Press search button in toolbar
159+ 3. Type a partial search term
160+ Expect to see results:- http://people.canonical.com/~alan/screenshots/device-2015-01-12-102618.png
161+
162+id: library/search-artists
163+plugin: manual
164+_summary: Test Search Artists
165+estimated_duration: 600
166+_description
167+ Test Search Artists
168+ 1. Navigate to Artists view
169+ 2. Press search button in toolbar
170+ 3. Type a partial search term
171+ Expect to see results:- http://people.canonical.com/~alan/screenshots/device-2015-01-12-102729.png
172+
173+id: library/search-songs
174+plugin: manual
175+_summary: Test Search Songs
176+estimated_duration: 600
177+_description
178+ Test Search Songs
179+ 1. Navigate to Songs view
180+ 2. Press search button in toolbar
181+ 3. Type a partial search term
182+ Expect to see results:- http://people.canonical.com/~alan/screenshots/device-2015-01-12-102836.png
183+
184+id: library/search-genres
185+plugin: manual
186+_summary: Test Search Genres
187+estimated_duration: 600
188+_description
189+ Test Search Genres
190+ 1. Navigate to Genres view
191+ 2. Press search button in toolbar
192+ 3. Type a partial search term
193+ Expect to see results:- http://people.canonical.com/~alan/screenshots/device-2015-01-12-102927.png
194+
195+id: library/search-playlists
196+plugin: manual
197+_summary: Test Search Genres
198+estimated_duration: 600
199+_description
200+ Test Search Genres
201+ 1. Note: This relies on an earlier test where a playlist was created
202+ 2. Navigate to Playlist view
203+ 3. Press search button in toolbar
204+ 4. Type a partial search term
205+ Expect to see results:- http://people.canonical.com/~alan/screenshots/device-2015-01-12-103017.png
206
207=== added file 'tests/manual/music_app/jobs/playlists.pxu'
208--- tests/manual/music_app/jobs/playlists.pxu 1970-01-01 00:00:00 +0000
209+++ tests/manual/music_app/jobs/playlists.pxu 2015-09-25 10:19:56 +0000
210@@ -0,0 +1,66 @@
211+id: playlists/create-playlists
212+plugin: manual
213+_summary: Test create playlist
214+estimated_duration: 600
215+_description
216+ Test create playlist
217+ 1. Open music app
218+ 2. Navigate to playlist view
219+ Expect empty playlist:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-101416.png
220+ 3. Tap "+" button in top right
221+ Expect "New Playlist" dialog:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-204544.png
222+ 4. Tap in the input field
223+ Expect to see the OSK appear:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205144.png
224+ 5. Type "Best songs"
225+ 6. Press Create
226+ Expect to see empty playlist:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205248.png
227+
228+id: playlists/add-tracks-to-playlist
229+plugin: manual
230+_summary: Test add tracks to playlist
231+estimated_duration: 600
232+_description
233+ Test add tracks to playlist
234+ 1. Navigate to Songs view
235+ 2. Slide left a song
236+ Expect to see buttons revealed:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205354.png
237+ 3. Tap last icon (add to playlist)
238+ Expect to be taken to "Select playlist" view:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205514.png
239+ 4. Select previously created playlist "Best songs"
240+ Expect to be taken back to previous view:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205552.png
241+ 5. Navigate to albums view
242+ 6. Tap on an album
243+ Expect to see the individual album view:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205713.png
244+ 7. Long press on a track
245+ Expect multi-select boxes and buttons to appear:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205819.png
246+ 8. Tap multiple songs
247+ 9. Tap 'burger' menu in the top right, choose "Add to playlist"
248+ Expect to be taken to the "Select playlist" view:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-205923.png
249+ 10. Tap previously create playlist
250+ Expect to be taken back to individual album view:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-210010.png
251+ 11. Navigate to Playlist view
252+ 12. Tap previously created playlist
253+ Expect to see songs previously selected:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-210333.png
254+
255+id: playlists/remove-playlist
256+plugin: manual
257+_summary: Test removing playlist
258+estimated_duration: 600
259+_description
260+ Test removing playlist
261+ 1. Navigate to Playlist view
262+ 2. Tap previously created playlist
263+ 3. Tap rubbish bin in top toolbar
264+ Expect to get a confirmation prompt:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-210424.png
265+ 4. Tap 'Remove' button
266+ Expect playlist to be removed:- http://people.canonical.com/~alan/screenshots/device-2014-11-17-210520.png
267+
268+id: playlists/tab-persist
269+plugin: manual
270+_summary: Test tab index is persists a restart
271+estimated_duration: 600
272+_description
273+ Test tab index is persists a restart
274+ 1. Start the app and switch to a tab (eg playlists)
275+ 2. Close the app and restart it
276+ Expect the app to start on the same tab
277
278=== added file 'tests/manual/music_app/jobs/queue.pxu'
279--- tests/manual/music_app/jobs/queue.pxu 1970-01-01 00:00:00 +0000
280+++ tests/manual/music_app/jobs/queue.pxu 2015-09-25 10:19:56 +0000
281@@ -0,0 +1,37 @@
282+id: queue/deletion-music
283+plugin: manual
284+_summary: Test deletion of music from queue
285+estimated_duration: 600
286+_description
287+ Test deletion of music from queue
288+ 1. Open music app
289+ 2. Select an album and play all
290+ Expect the album to start playing and that single album to be in the queue
291+ 3. Delete the entire album from the device
292+ Expect the view to be 'popped' back to the Albums view
293+ Expect the music to be stopped and the queue to be empty
294+
295+id: queue/sd-card-remove
296+plugin: manual
297+_summary: Test removing SD Card during playback
298+estimated_duration: 600
299+_description
300+ Test removing SD Card during playback
301+ 1. (only applicable on devices with sdcard support)
302+ 2. Add some songs to an SD card
303+ 3. Queue up an album which is on the SD card
304+ 4. Start playing tracks from the queue
305+ 5. Remove the SD Card
306+ Expect tracks which are no longer accessible should disappear from the queue
307+
308+id: queue/restart
309+plugin: manual
310+_summary: Test queue persists a restart
311+estimated_duration: 600
312+_description
313+ Test queue persists a restart
314+ 1. Start the app
315+ 2. Add a few albums to the queue
316+ 3. Take note of the queue and current track
317+ 4. Restart the app
318+ Expect the queue to be restored and the same track to be selected
319
320=== added file 'tests/manual/music_app/jobs/recent.pxu'
321--- tests/manual/music_app/jobs/recent.pxu 1970-01-01 00:00:00 +0000
322+++ tests/manual/music_app/jobs/recent.pxu 2015-09-25 10:19:56 +0000
323@@ -0,0 +1,21 @@
324+id: recent/recent-appears
325+plugin: manual
326+_summary: Test recent tab appears
327+estimated_duration: 600
328+_description
329+ Test recent tab appears
330+ 1. Goto the album view
331+ 2. Select an album and play all
332+ Expect the recent tab to appear
333+ 3. Navigate to the recent tab ensure that the album is correct
334+
335+id: recent/recent-disappears
336+plugin: manual
337+_summary: Test recent tab disappears
338+estimated_duration: 600
339+_description
340+ Test recent tab disappears
341+ 1. Ensure that the recent tab is visible and switch to the tab
342+ 2. Select clear all action
343+ Expect to be switched to the albums tab
344+ Expect the recent tab to have been removed

Subscribers

People subscribed via source and target branches