Merge ~ahasenack/ubuntu/+source/volatildap:focal-volatildap-apparmor-dep8 into ~ahasenack/ubuntu/+source/volatildap:master
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Andreas Hasenack | ||||
Approved revision: | 7141d193d5f5f8440464ce5caa9b323f60c484be | ||||
Merge reported by: | Andreas Hasenack | ||||
Merged at revision: | 7141d193d5f5f8440464ce5caa9b323f60c484be | ||||
Proposed branch: | ~ahasenack/ubuntu/+source/volatildap:focal-volatildap-apparmor-dep8 | ||||
Merge into: | ~ahasenack/ubuntu/+source/volatildap:master | ||||
Diff against target: |
75 lines (+39/-3) 4 files modified
debian/changelog (+8/-0) debian/control (+2/-1) debian/tests/control (+2/-2) debian/tests/run-tests (+27/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lucas Kanashiro (community) | Approve | ||
Canonical Server MOTU reviewers | Pending | ||
Review via email: mp+377337@code.launchpad.net |
Description of the change
volatildap is one of the packages blocking the openldap migation due to DEP8 failures.
This package isn't imported into git-ubuntu, so I did a "gbp import-dsc", and am proposing my changes on top of that.
The DEP8 tests are failing in Ubuntu because of the slapd (openldap daemon) apparmor profile, which doesn't allow the daemon to have its config file and other things in /tmp.
I don't know beforehand which temporary directory will be used in /tmp, since it's random. I could have patched the python code instead and created the apparmor local profile override at that time with a more specific path, but it didn't feel worth it.
I checked debian and it's passing there, as they aren't using apparmor in openldap yet (it's part of our openldap delta), so probably not worth sending to them either.
Here is a run under lxd:
autopkgtest [18:18:36]: test run-tests: [------
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
running egg_info
writing volatildap.
writing dependency_links to volatildap.
writing top-level names to volatildap.
reading manifest file 'volatildap.
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '*.py[cod]' found anywhere in distribution
warning: no previously-included files matching '__pycache__' found anywhere in distribution
warning: no previously-included files matching '*.swp' found anywhere in distribution
writing manifest file 'volatildap.
running build_ext
test_stop (tests.
Deleting the LdapServer object causes its cleanup. ... config file testing succeeded
ok
test_clear_data (tests.
ok
test_get_
ok
test_initial_data (tests.
ok
test_post_start_add (tests.
ok
test_cleanup (tests.
ok
test_connection (tests.
ok
-------
Ran 7 tests in 4.249s
Why do we need breaks-testbed restriction in this test Andreas? The test works fine without it, that's why I am asking. Other than that it LGTM.