Merge ~ahasenack/ubuntu/+source/sssd:bionic-sssd-max-id-1807246 into ubuntu/+source/sssd:ubuntu/bionic-devel
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Robie Basak | ||||||||
Approved revision: | df51bf9daad357cdecf99d43de3eecc329285095 | ||||||||
Merged at revision: | df51bf9daad357cdecf99d43de3eecc329285095 | ||||||||
Proposed branch: | ~ahasenack/ubuntu/+source/sssd:bionic-sssd-max-id-1807246 | ||||||||
Merge into: | ubuntu/+source/sssd:ubuntu/bionic-devel | ||||||||
Diff against target: |
617 lines (+561/-0) 9 files modified
debian/changelog (+11/-0) debian/patches/fix-id-out-of-range-lookup.patch (+117/-0) debian/patches/series (+1/-0) debian/tests/common-tests (+28/-0) debian/tests/control (+7/-0) debian/tests/ldap-user-group-krb5-auth (+35/-0) debian/tests/ldap-user-group-ldap-auth (+29/-0) debian/tests/login.exp (+74/-0) debian/tests/util (+259/-0) |
||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robie Basak | Approve | ||
Canonical Server | Pending | ||
Review via email: mp+361848@code.launchpad.net |
Description of the change
Bileto ticket and ppa, with green dep8 tests: https:/
Upstream fix for bug #1807246. Since sssd always requires a somewhat complicated setup to test, I decided to also include the DEP8 tests we have added to the package in cosmic and later. To that end, I added a bionic task to #1793882 and included them here. I believe this gives more confidence in this particular update for an LTS, and also future updates of sssd.
I debated if I should pick just the one-liner that is the real fix, or the whole upstream commit. I chose the latter, since it applied cleanly, but one could argue that the SRU spirit means I should have picked the one-liner. I can see it getting in the way of future patches because of unecessary noise, but at the same time it is closer to upstream, which is where future patches are developed.
The bug has the SRU template filled out, and the testing instructions can be followed there.
dep8 tests are now identical to those on the development release
The new fix-id- out-of- range-lookup. patch is identical to the upstream commit (except for added dep3 headers)
Version string in changelog correct, no collisions
Changelog message looks good with correct bug references.
No other changes.
SRU information prepared and complete
Whitespace changes are great but I agree they're trivial enough that it's cleaner to do this than diverge from the upstream patch. Thank you for explaining your reasoning on this.
The patch itself looks fine.
Upload and SRU +1