Merge ~ahasenack/ubuntu/+source/squid3:xenial-squid-reload-1738412 into ubuntu/+source/squid3:ubuntu/xenial-devel
Proposed by
Andreas Hasenack
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Andreas Hasenack | ||||
Approved revision: | 952103bbf339cabc5fbe17214eb6909d2f23652e | ||||
Merged at revision: | 952103bbf339cabc5fbe17214eb6909d2f23652e | ||||
Proposed branch: | ~ahasenack/ubuntu/+source/squid3:xenial-squid-reload-1738412 | ||||
Merge into: | ubuntu/+source/squid3:ubuntu/xenial-devel | ||||
Diff against target: |
110 lines (+25/-14) 5 files modified
debian/changelog (+12/-0) debian/squid.rc (+3/-3) debian/tests/control (+1/-1) debian/tests/squid (+5/-0) debian/tests/test-squid.py (+4/-10) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Approve | ||
Canonical Server | Pending | ||
Canonical Server packageset reviewers | Pending | ||
Review via email: mp+358050@code.launchpad.net |
Description of the change
Fixes the regexp used to detect problems in the squid configuration file.
The (SRU) bug has test details, and regression considerations.
I also took the oportunity to fix the DEP8 tests for xenial. I have a bileto run, but can't get to the test logs there, so I uploaded the results here: http://
Bileto ticket: https:/
I debated adding a python-minimal dependency to d/t/control. I can still do that if preferred, it just seems unecessary.
To post a comment you must log in.
The changes LGTM +1 for those.
I read and thought about the regression potential twice, but I like the "explicitly broken" much more than "silently broken". I think it is good that you outlined it in the bug, but I'd want the change and not see it as a bad thing.