Merge ~ahasenack/ubuntu/+source/sg3-utils:noble-lib-conflict-2039279 into ubuntu/+source/sg3-utils:ubuntu/devel

[Andreas Hasenack]

Update the package version in the breaks/replaces to match the ubuntu versions of this package that are affected by the file conflict.

PPA: https://launchpad.net/~ahasenack/+archive/ubuntu/sg3-utils-file-conflict-2039279/+packages

These are the affected ubuntu releases with conflicting files:

Jammy: 1.46-1build1
package: libsgutils2-2
ships: libsgutils2-1.46.so.2 and libsgutils2-1.46.so.2.0.0

Lunar: 1.46-1ubuntu0.23.04.1
package: libsgutils2-2
ships: libsgutils2-1.46.so.2 and libsgutils2-1.46.so.2.0.0

Mantic and Noble: 1.46-3ubuntu2
package: libsgutils2-1.46-2
ships: libsgutils2-1.46.so.2 and libsgutils2-1.46.so.2.0.0

Upgrades from jammy to mantic will also see this bug, when lunar goes EOL.

This seems to be one of the unsolved cases in the debian package transitioning guide[1]. We need a breaks/replaces for all versions in jammy and lunar, including updates that are yet to become available. In summary, anything 1.46-1*.

If we do:
Breaks: libsgutils2-2 (<< 1.46-3ubuntu2)
Replaces: libsgutils2-2 (<< 1.46-3ubuntu2)

This will include versions like focal's 1.44-1ubuntu2, which isn't affected (the library file there was still called libsgutils2.so.2, so no file conflict). That being said, we don't expect someone from focal to upgrade to mantic without going through jammy first, at least. And once in jammy, the version in B/R from mantic is correctly targeting the jammy version.

I think this the correct fix, but welcome other opinions or ways to address the problem.

[Athos Ribeiro (athos-ribeiro)]

As per my comments in https://code.launchpad.net/~ahasenack/ubuntu/+source/sg3-utils/+git/sg3-utils/+merge/454497, this LGTM

review: Approve

[git-ubuntu bot (git-ubuntu-bot)]

Approvers: ahasenack, athos-ribeiro
Uploaders: ahasenack, athos-ribeiro
MP auto-approved

review: Approve

[Lucas Kanashiro (lucaskanashiro)]

Just a comment regarding this fix: if for some reason someone updates sg3-utils to a newer upstream micro release in Jammy (Lunar will be EOL soon anyway) this problem might come up again. This is an unlikely event but it is something that might happen, and we need to keep an eye on future SRUs.

diff --git a/debian/changelog b/debian/changelog
index b567c06..47d3243 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+sg3-utils (1.46-3ubuntu3) noble; urgency=medium
+
+  * d/control: fix version in libsgutils2-1.46-2 breaks/replaces to
+    avoid file conflict when ugprading from jammy and lunar
+    (LP: #2039279)
+
+ -- Andreas Hasenack <[e-mail]>  Wed, 25 Oct 2023 09:49:58 -0300
+
 sg3-utils (1.46-3ubuntu2) mantic; urgency=medium
 
   * d/p/0002-Fix-crash-with-rescan-scsi-bus.sh-r.patch: do not allow
diff --git a/debian/control b/debian/control
index 1184a2a..2b00df9 100644
--- a/debian/control
+++ b/debian/control
@@ -29,8 +29,8 @@ Package: libsgutils2-1.46-2
 Section: libs
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Architecture: any
-Breaks: libsgutils2-2 (= 1.46-1build1)
-Replaces: libsgutils2-2 (= 1.46-1build1)
+Breaks: libsgutils2-2 (<< 1.46-3ubuntu2)
+Replaces: libsgutils2-2 (<< 1.46-3ubuntu2)
 Suggests: sg3-utils
 Multi-Arch: same
 Description: utilities for devices using the SCSI command set (shared libraries)