Merge ~ahasenack/ubuntu/+source/samba:cosmic-samba-rmdir-1795772 into ubuntu/+source/samba:ubuntu/devel
Status: | Merged |
---|---|
Approved by: | Andreas Hasenack |
Approved revision: | ce0fe6a620fc88cb9b138fec72218137e70db2eb |
Merged at revision: | ce0fe6a620fc88cb9b138fec72218137e70db2eb |
Proposed branch: | ~ahasenack/ubuntu/+source/samba:cosmic-samba-rmdir-1795772 |
Merge into: | ubuntu/+source/samba:ubuntu/devel |
Diff against target: |
79 lines (+57/-0) 3 files modified
debian/changelog (+8/-0) debian/patches/fix-rmdir.patch (+48/-0) debian/patches/series (+1/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Approve | ||
Canonical Server | Pending | ||
Canonical Server Core Reviewers | Pending | ||
Review via email: mp+356356@code.launchpad.net |
Description of the change
This MP is superseeding Karl's one at https:/
Bileto ticket: https:/
PPA (still building): ppa:ci-
This branch fixes the case where rmdir fails to remove a non-empty directory but returns successfully, indicating to the caller that all went well. It's a bug in the library and affects many client tools, like smbclient and GUI file browsers.
Testing instructions, taken from Karl's work:
# lxc launch ubuntu-daily:cosmic sambatest
# lxc exec sambatest bash
# apt update
# apt dist-upgrade -y
# apt install -y samba samba-client
# mkdir -p /tmp/shared/
# chown -R nobody:nogroup /tmp/shared
# printf "%s" "[global]
workgroup = WORKGROUP
server role = standalone server
security = user
map to guest = Bad User
guest ok = yes
guest only = yes
guest account = nobody
[shared]
path = /tmp/shared
writable = yes
browsable = yes
guest ok = yes
" | tee "/etc/samba/
# service smbd restart
# CLI_FORCE_
rmdir testdir
quit
EOF
* This will not report an error, but it should.
With the updated packages, the smbclient call will correctly report that the directory is not empty.
Update scan failed
At least one of the branches involved have failed to scan. You can manually schedule a rescan if required.
Only gvfs failed on s390x so far, all other dep8 tests passed. I clicked retry, let's see tomorrow.