Merge ~ahasenack/ubuntu/+source/pppconfig:oracular-pppconfig-ftbfs-po4a into ubuntu/+source/pppconfig:ubuntu/devel

Proposed by Andreas Hasenack
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merged at revision: 7e9180b57247fdc689cb75e878a8d4daadcb4117
Proposed branch: ~ahasenack/ubuntu/+source/pppconfig:oracular-pppconfig-ftbfs-po4a
Merge into: ubuntu/+source/pppconfig:ubuntu/devel
Diff against target: 59 lines (+14/-4)
4 files modified
debian/changelog (+8/-0)
debian/control (+2/-1)
man/po/pppconfig.pot (+2/-2)
man/po4a.cfg (+2/-1)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Athos Ribeiro (community) Approve
Canonical Server Core Reviewers Pending
Canonical Server Reporter Pending
Review via email: mp+472165@code.launchpad.net

Description of the change

Part 1 of the fix for LP: #2078254. Source of the patch is in the commit message.

The second part is in the po4a package, subject to another PR.

PPA: https://launchpad.net/~ahasenack/+archive/ubuntu/ftbfs-oracular/+packages

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos) wrote :

LGTM; I added an inline comment for the changelog: I do not think we do need the author name in brackets in the beginning of the changelog given they are the only author here.

Feel free to upload after evaluating and possibly acting upon the comment though :)

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) :
Revision history for this message
Andreas Hasenack (ahasenack) wrote (last edit ):

This can only be uploaded after po4a (https://code.launchpad.net/~ahasenack/ubuntu/+source/po4a/+git/po4a/+merge/472166 is in proposed.

Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: ahasenack, athos-ribeiro
Uploaders: ahasenack, athos-ribeiro
MP auto-approved

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Uploaded after po4a got published:
Uploading pppconfig_2.3.28ubuntu1.dsc
Uploading pppconfig_2.3.28ubuntu1.tar.xz
Uploading pppconfig_2.3.28ubuntu1_source.buildinfo
Uploading pppconfig_2.3.28ubuntu1_source.changes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 344ecaa..3786177 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
1pppconfig (2.3.28ubuntu1) oracular; urgency=medium
2
3 * man/po/pppconfig.pot, man/po4a.cfg: specify that the french addendum has
4 encoding iso-8859-1. Fixes build with new po4a (Closes: #107260
5 LP: #2078254)
6
7 -- Alessandro Astone <alessandro.astone@canonical.com> Tue, 20 Aug 2024 15:20:42 +0200
8
1pppconfig (2.3.28) unstable; urgency=medium9pppconfig (2.3.28) unstable; urgency=medium
210
3 * QA upload.11 * QA upload.
diff --git a/debian/control b/debian/control
index d9e270d..2363e72 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
1Source: pppconfig1Source: pppconfig
2Section: admin2Section: admin
3Priority: optional3Priority: optional
4Maintainer: Debian QA Group <packages@qa.debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Debian QA Group <packages@qa.debian.org>
5Standards-Version: 3.9.26Standards-Version: 3.9.2
6Build-Depends-Indep: debianutils (>= 2.10.3)7Build-Depends-Indep: debianutils (>= 2.10.3)
7Build-Depends: debhelper-compat (= 10), pkgconf, po4a, systemd-dev8Build-Depends: debhelper-compat (= 10), pkgconf, po4a, systemd-dev
diff --git a/man/po/pppconfig.pot b/man/po/pppconfig.pot
index f9ec2dc..a127789 100644
--- a/man/po/pppconfig.pot
+++ b/man/po/pppconfig.pot
@@ -7,13 +7,13 @@
7msgid ""7msgid ""
8msgstr ""8msgstr ""
9"Project-Id-Version: PACKAGE VERSION\n"9"Project-Id-Version: PACKAGE VERSION\n"
10"POT-Creation-Date: 2011-06-07 20:27+0300\n"10"POT-Creation-Date: 2024-08-20 15:22+0200\n"
11"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"11"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
12"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"12"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
13"Language-Team: LANGUAGE <LL@li.org>\n"13"Language-Team: LANGUAGE <LL@li.org>\n"
14"Language: \n"14"Language: \n"
15"MIME-Version: 1.0\n"15"MIME-Version: 1.0\n"
16"Content-Type: text/plain; charset=CHARSET\n"16"Content-Type: text/plain; charset=UTF-8\n"
17"Content-Transfer-Encoding: 8bit\n"17"Content-Transfer-Encoding: 8bit\n"
1818
19#. type: TH19#. type: TH
diff --git a/man/po4a.cfg b/man/po4a.cfg
index d8df7dc..9f4c756 100644
--- a/man/po4a.cfg
+++ b/man/po4a.cfg
@@ -1,2 +1,3 @@
1[po4a_paths] man/po/pppconfig.pot fr:man/po/fr.po de:man/po/de.po pt:man/po/pt.po1[po4a_paths] man/po/pppconfig.pot fr:man/po/fr.po de:man/po/de.po pt:man/po/pt.po
2[type: man] man/pppconfig.8 fr:man/pppconfig.fr.8 add_fr:man/pppconfig.add.fr de:man/pppconfig.de.8 add_de:man/pppconfig.add.de pt:man/pppconfig.pt.82[type: man] man/pppconfig.8 fr:man/pppconfig.fr.8 add_fr:man/pppconfig.add.fr de:man/pppconfig.de.8 add_de:man/pppconfig.add.de pt:man/pppconfig.pt.8 \
3 opt_fr:"--addendum-charset iso-8859-1"

Subscribers

People subscribed via source and target branches